Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update qhimm.xml #209

Merged
merged 4 commits into from
Nov 24, 2024
Merged

Conversation

bradhowlett
Copy link
Contributor

I believe I have everything right. I hope

Copy link
Member

@julianxhokaxhiu julianxhokaxhiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there :) In your mod.xml you miss the tag <ID> which must the same used here in the catalog ( as it has to match ). This is required to make sure all mods are unique in the catalog and they don't clash by the name. Thanks!

@bradhowlett
Copy link
Contributor Author

bradhowlett commented Nov 22, 2024 via email

@bradhowlett
Copy link
Contributor Author

Ok thank you. I will work on that as wellSincerely Brad HowlettOn Nov 22, 2024, at 11:20 AM, Julian Xhokaxhiu @.> wrote: @julianxhokaxhiu requested changes on this pull request. Almost there :) In your mod.xml you miss the tag which must the same used here in the catalog ( as it has to match ). This is required to make sure all mods are unique in the catalog and they don't clash by the name. Thanks! —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.>

I added the ID to the mod.xml. I then reuploaded everything. I did change the gdrive ID in my PR to target the new file with the fixed mod.xml.

@julianxhokaxhiu
Copy link
Member

Thanks, I'm checking the PR but the download of the drive file seems to be the same as before ( and if I try to access it says it doesn't exist ). Did you commit the change to the same branch where you've opened the PR from?

@bradhowlett
Copy link
Contributor Author

bradhowlett commented Nov 23, 2024 via email

fixed GDrive link
@bradhowlett
Copy link
Contributor Author

bradhowlett commented Nov 23, 2024 via email

This commit is if you are needing the GDrive ID to be the IRO.
The previous commit from 20 minutes ago is if the GDrive ID needs to be the entire folder.
@bradhowlett
Copy link
Contributor Author

I created 2 commits today. The first is if the GDrive ID needs to point to my entire mod folder and the second is if it just needs to point to the iro

updated file size to kb
@julianxhokaxhiu julianxhokaxhiu merged commit 5a80d9a into tsunamods-codes:master Nov 24, 2024
1 check passed
@julianxhokaxhiu
Copy link
Member

Well done :) Merged and tested, all works as intended, thank you and congratulations!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants