Skip to content

mesh quality metrics #146

mesh quality metrics

mesh quality metrics #146

GitHub Actions / clippy failed Dec 17, 2024 in 0s

clippy

15 errors, 2 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 15
Warning 2
Note 0
Help 0

Versions

  • rustc 1.83.0 (90b35a623 2024-11-26)
  • cargo 1.83.0 (5ffbef321 2024-10-29)
  • clippy 0.1.83 (90b35a6 2024-11-26)

Annotations

Check failure on line 596 in src/mesh.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

needless use of `for_each`

error: needless use of `for_each`
   --> src/mesh.rs:592:21
    |
592 | /                     res.unwrap().for_each(|(i, j, v)| {
593 | |                         ids.push(i);
594 | |                         ids.push(j);
595 | |                         vals.push(v);
596 | |                     });
    | |_______________________^
...
623 |   create_mesh!(Mesh21, 2, Edge);
    |   ----------------------------- in this macro invocation
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_for_each
    = note: this error originates in the macro `create_mesh` (in Nightly builds, run with -Z macro-backtrace for more info)
help: try
    |
592 ~                     for (i, j, v) in res.unwrap() {
593 +                         ids.push(i);
594 +                         ids.push(j);
595 +                         vals.push(v);
596 +                     }
    |

Check failure on line 585 in src/mesh.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this function has a `#[must_use]` attribute with no message, but returns a type already marked as `#[must_use]`

error: this function has a `#[must_use]` attribute with no message, but returns a type already marked as `#[must_use]`
   --> src/mesh.rs:585:13
    |
585 |             pub fn face_skewnesses<'py>(&self, py: Python<'py>) -> PyResult<(Bound<'py, PyArray2<Idx>>, Bound<'py, PyArray1<f64>>)> {
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
...
623 | create_mesh!(Mesh21, 2, Edge);
    | ----------------------------- in this macro invocation
    |
    = help: either add some descriptive message or remove the attribute
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_must_use
    = note: this error originates in the macro `create_mesh` (in Nightly builds, run with -Z macro-backtrace for more info)

Check failure on line 596 in src/mesh.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

needless use of `for_each`

error: needless use of `for_each`
   --> src/mesh.rs:592:21
    |
592 | /                     res.unwrap().for_each(|(i, j, v)| {
593 | |                         ids.push(i);
594 | |                         ids.push(j);
595 | |                         vals.push(v);
596 | |                     });
    | |_______________________^
...
622 |   create_mesh!(Mesh22, 2, Triangle);
    |   --------------------------------- in this macro invocation
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_for_each
    = note: this error originates in the macro `create_mesh` (in Nightly builds, run with -Z macro-backtrace for more info)
help: try
    |
592 ~                     for (i, j, v) in res.unwrap() {
593 +                         ids.push(i);
594 +                         ids.push(j);
595 +                         vals.push(v);
596 +                     }
    |

Check failure on line 585 in src/mesh.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this function has a `#[must_use]` attribute with no message, but returns a type already marked as `#[must_use]`

error: this function has a `#[must_use]` attribute with no message, but returns a type already marked as `#[must_use]`
   --> src/mesh.rs:585:13
    |
585 |             pub fn face_skewnesses<'py>(&self, py: Python<'py>) -> PyResult<(Bound<'py, PyArray2<Idx>>, Bound<'py, PyArray1<f64>>)> {
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
...
622 | create_mesh!(Mesh22, 2, Triangle);
    | --------------------------------- in this macro invocation
    |
    = help: either add some descriptive message or remove the attribute
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_must_use
    = note: this error originates in the macro `create_mesh` (in Nightly builds, run with -Z macro-backtrace for more info)

Check failure on line 596 in src/mesh.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

needless use of `for_each`

error: needless use of `for_each`
   --> src/mesh.rs:592:21
    |
592 | /                     res.unwrap().for_each(|(i, j, v)| {
593 | |                         ids.push(i);
594 | |                         ids.push(j);
595 | |                         vals.push(v);
596 | |                     });
    | |_______________________^
...
621 |   create_mesh!(Mesh31, 3, Edge);
    |   ----------------------------- in this macro invocation
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_for_each
    = note: this error originates in the macro `create_mesh` (in Nightly builds, run with -Z macro-backtrace for more info)
help: try
    |
592 ~                     for (i, j, v) in res.unwrap() {
593 +                         ids.push(i);
594 +                         ids.push(j);
595 +                         vals.push(v);
596 +                     }
    |

Check failure on line 585 in src/mesh.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this function has a `#[must_use]` attribute with no message, but returns a type already marked as `#[must_use]`

error: this function has a `#[must_use]` attribute with no message, but returns a type already marked as `#[must_use]`
   --> src/mesh.rs:585:13
    |
585 |             pub fn face_skewnesses<'py>(&self, py: Python<'py>) -> PyResult<(Bound<'py, PyArray2<Idx>>, Bound<'py, PyArray1<f64>>)> {
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
...
621 | create_mesh!(Mesh31, 3, Edge);
    | ----------------------------- in this macro invocation
    |
    = help: either add some descriptive message or remove the attribute
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_must_use
    = note: this error originates in the macro `create_mesh` (in Nightly builds, run with -Z macro-backtrace for more info)

Check failure on line 596 in src/mesh.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

needless use of `for_each`

error: needless use of `for_each`
   --> src/mesh.rs:592:21
    |
592 | /                     res.unwrap().for_each(|(i, j, v)| {
593 | |                         ids.push(i);
594 | |                         ids.push(j);
595 | |                         vals.push(v);
596 | |                     });
    | |_______________________^
...
620 |   create_mesh!(Mesh32, 3, Triangle);
    |   --------------------------------- in this macro invocation
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_for_each
    = note: this error originates in the macro `create_mesh` (in Nightly builds, run with -Z macro-backtrace for more info)
help: try
    |
592 ~                     for (i, j, v) in res.unwrap() {
593 +                         ids.push(i);
594 +                         ids.push(j);
595 +                         vals.push(v);
596 +                     }
    |

Check failure on line 585 in src/mesh.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this function has a `#[must_use]` attribute with no message, but returns a type already marked as `#[must_use]`

error: this function has a `#[must_use]` attribute with no message, but returns a type already marked as `#[must_use]`
   --> src/mesh.rs:585:13
    |
585 |             pub fn face_skewnesses<'py>(&self, py: Python<'py>) -> PyResult<(Bound<'py, PyArray2<Idx>>, Bound<'py, PyArray1<f64>>)> {
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
...
620 | create_mesh!(Mesh32, 3, Triangle);
    | --------------------------------- in this macro invocation
    |
    = help: either add some descriptive message or remove the attribute
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_must_use
    = note: this error originates in the macro `create_mesh` (in Nightly builds, run with -Z macro-backtrace for more info)

Check failure on line 596 in src/mesh.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

needless use of `for_each`

error: needless use of `for_each`
   --> src/mesh.rs:592:21
    |
592 | /                     res.unwrap().for_each(|(i, j, v)| {
593 | |                         ids.push(i);
594 | |                         ids.push(j);
595 | |                         vals.push(v);
596 | |                     });
    | |_______________________^
...
619 |   create_mesh!(Mesh33, 3, Tetrahedron);
    |   ------------------------------------ in this macro invocation
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_for_each
    = note: `-D clippy::needless-for-each` implied by `-D clippy::pedantic`
    = help: to override `-D clippy::pedantic` add `#[allow(clippy::needless_for_each)]`
    = note: this error originates in the macro `create_mesh` (in Nightly builds, run with -Z macro-backtrace for more info)
help: try
    |
592 ~                     for (i, j, v) in res.unwrap() {
593 +                         ids.push(i);
594 +                         ids.push(j);
595 +                         vals.push(v);
596 +                     }
    |

Check failure on line 585 in src/mesh.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this function has a `#[must_use]` attribute with no message, but returns a type already marked as `#[must_use]`

error: this function has a `#[must_use]` attribute with no message, but returns a type already marked as `#[must_use]`
   --> src/mesh.rs:585:13
    |
585 |             pub fn face_skewnesses<'py>(&self, py: Python<'py>) -> PyResult<(Bound<'py, PyArray2<Idx>>, Bound<'py, PyArray1<f64>>)> {
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
...
619 | create_mesh!(Mesh33, 3, Tetrahedron);
    | ------------------------------------ in this macro invocation
    |
    = help: either add some descriptive message or remove the attribute
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_must_use
    = note: `-D clippy::double-must-use` implied by `-D clippy::all`
    = help: to override `-D clippy::all` add `#[allow(clippy::double_must_use)]`
    = note: this error originates in the macro `create_mesh` (in Nightly builds, run with -Z macro-backtrace for more info)

Check failure on line 598 in src/mesh.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

redundant else block

error: redundant else block
   --> src/mesh.rs:589:24
    |
589 |                   } else {
    |  ________________________^
590 | |                     let mut ids = Vec::new();
591 | |                     let mut vals = Vec::new();
592 | |                     res.unwrap().for_each(|(i, j, v)| {
...   |
597 | |                     Ok((to_numpy_2d(py, ids, 2), to_numpy_1d(py, vals)))
598 | |                 }
    | |_________________^
...
623 |   create_mesh!(Mesh21, 2, Edge);
    |   ----------------------------- in this macro invocation
    |
    = help: remove the `else` block and move the contents out
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_else
    = note: this error originates in the macro `create_mesh` (in Nightly builds, run with -Z macro-backtrace for more info)

Check failure on line 598 in src/mesh.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

redundant else block

error: redundant else block
   --> src/mesh.rs:589:24
    |
589 |                   } else {
    |  ________________________^
590 | |                     let mut ids = Vec::new();
591 | |                     let mut vals = Vec::new();
592 | |                     res.unwrap().for_each(|(i, j, v)| {
...   |
597 | |                     Ok((to_numpy_2d(py, ids, 2), to_numpy_1d(py, vals)))
598 | |                 }
    | |_________________^
...
622 |   create_mesh!(Mesh22, 2, Triangle);
    |   --------------------------------- in this macro invocation
    |
    = help: remove the `else` block and move the contents out
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_else
    = note: this error originates in the macro `create_mesh` (in Nightly builds, run with -Z macro-backtrace for more info)

Check failure on line 598 in src/mesh.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

redundant else block

error: redundant else block
   --> src/mesh.rs:589:24
    |
589 |                   } else {
    |  ________________________^
590 | |                     let mut ids = Vec::new();
591 | |                     let mut vals = Vec::new();
592 | |                     res.unwrap().for_each(|(i, j, v)| {
...   |
597 | |                     Ok((to_numpy_2d(py, ids, 2), to_numpy_1d(py, vals)))
598 | |                 }
    | |_________________^
...
621 |   create_mesh!(Mesh31, 3, Edge);
    |   ----------------------------- in this macro invocation
    |
    = help: remove the `else` block and move the contents out
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_else
    = note: this error originates in the macro `create_mesh` (in Nightly builds, run with -Z macro-backtrace for more info)

Check failure on line 598 in src/mesh.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

redundant else block

error: redundant else block
   --> src/mesh.rs:589:24
    |
589 |                   } else {
    |  ________________________^
590 | |                     let mut ids = Vec::new();
591 | |                     let mut vals = Vec::new();
592 | |                     res.unwrap().for_each(|(i, j, v)| {
...   |
597 | |                     Ok((to_numpy_2d(py, ids, 2), to_numpy_1d(py, vals)))
598 | |                 }
    | |_________________^
...
620 |   create_mesh!(Mesh32, 3, Triangle);
    |   --------------------------------- in this macro invocation
    |
    = help: remove the `else` block and move the contents out
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_else
    = note: this error originates in the macro `create_mesh` (in Nightly builds, run with -Z macro-backtrace for more info)

Check failure on line 598 in src/mesh.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

redundant else block

error: redundant else block
   --> src/mesh.rs:589:24
    |
589 |                   } else {
    |  ________________________^
590 | |                     let mut ids = Vec::new();
591 | |                     let mut vals = Vec::new();
592 | |                     res.unwrap().for_each(|(i, j, v)| {
...   |
597 | |                     Ok((to_numpy_2d(py, ids, 2), to_numpy_1d(py, vals)))
598 | |                 }
    | |_________________^
...
619 |   create_mesh!(Mesh33, 3, Tetrahedron);
    |   ------------------------------------ in this macro invocation
    |
    = help: remove the `else` block and move the contents out
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_else
    = note: `-D clippy::redundant-else` implied by `-D clippy::pedantic`
    = help: to override `-D clippy::pedantic` add `#[allow(clippy::redundant_else)]`
    = note: this error originates in the macro `create_mesh` (in Nightly builds, run with -Z macro-backtrace for more info)