Recap Navigation #12
Merged
Recap Navigation #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Adds a left and right sidenav to the recap pages. - The left sidenav lists all of the recaps and lets you navigate between them. - The right sidenav lists the table of contents and where you're at on the page Had to modify the CSS of the page a bit to get this working, seems like there are some bugs with skeleton UI's setup.
There's probably a more elegant way but I wanted to keep " Recap" in the title and didn't want to pass extra metadata, so I'm just removing it from within the actual sidenav component.
Adds the league name to the navbar and makes it a clickable link that brings you back to the main league page. For leagues that have an avatar image set, also adds that image to the navbar.
Since we had to change the main scrolling element to be the body, it messed up the scroll position when navigating between pages. So as a workaround, adding an automatic scroll to top that runs after you navigate.
Adds a button at the top of the post page that lets you navigate to other posts. Only appears on smaller screens, since on large screens you can use the sidenav. While implementing this, I found the transition animation to be distracting. I don't like that it results in the sidenav animating. So I removed that for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4
Adds a few navigational elements to the page including:
Still TODO: