Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated mambaforge installer in CI #264

Merged

Conversation

niketagrawal
Copy link

@niketagrawal niketagrawal commented Nov 18, 2024

@DominicDirkx
Copy link
Member

Looks like the code is now passing the unit tests. Does anything remain to be tested before we merge?

@niketagrawal
Copy link
Author

niketagrawal commented Nov 19, 2024

Looks like the code is now passing the unit tests. Does anything remain to be tested before we merge?

Yes, the warning for the deprecated mambaforge installer is no longer present. Also, the build and unit tests pass.

I notice that the step in the workflow responsible for caching the conda environment for subsequent runs is failing for Linux and Windows because the path where conda env is located on the runner and where the CI workflow looks for it to cache do not match. This is not related to changes in this PR, but due to changes on the end of conda.

conda_cahce_step_fails

I have added the fix and re-run the CI to test if the the conda environment is cached successfully at the end of the workflow.

@niketagrawal niketagrawal self-assigned this Nov 19, 2024
@niketagrawal niketagrawal added the bug Something isn't working label Nov 19, 2024
@niketagrawal niketagrawal linked an issue Nov 19, 2024 that may be closed by this pull request
@niketagrawal
Copy link
Author

Conda cache step works as expected again after adding the above fix.

@niketagrawal niketagrawal marked this pull request as ready for review November 20, 2024 08:34
@DominicDirkx DominicDirkx merged commit b81dc02 into develop Nov 20, 2024
4 checks passed
@niketagrawal niketagrawal deleted the fix-243-remove-deprecated-mambaforge-installer-CI branch November 20, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI fails due to deprecated Mambaforge installer
2 participants