chore: add/configure code style toolchain #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helmturner
requested review from
zenlex,
CKCarr and
deino475
and removed request for
zenlex
CKCarr
previously approved these changes
Feb 18, 2024
This reverts commit 06525d5.
TS doesn't choke on comments in tsconfig.json
- removed referencces to expensify - removed/fixed parts that were irrelevent to this project - added 'single source of truth' file for globals/module augmentation
zenlex
previously approved these changes
Feb 21, 2024
Also removes redundant options that were previously explicit see: https://techlahoma.slack.com/archives/C061ADYPHNJ/p1708476318174819
helmturner
changed the title
|
There's a bit of overlap with the style enforcement tools, so I'm just lumping them in one PR |
helmturner
force-pushed
the
chore/with-formatting
branch
from
a463b3f to
a3463cc
Compare
tabs reached consensus based on the misconception that 1 tab is 2 spaces
helmturner
force-pushed
the
chore/with-formatting
branch
from
578e65b to
d5cfccc
Compare
|
Well, it doesn't get us linting in astro files... but we get TS and Prettier, so I'm cool with it. The linting rules will almost definitely need some fine tuning, but they're pretty comprehensive to start. As we get feedback we can fine tune them where appropriate. |
helmturner
force-pushed
the
chore/with-formatting
branch
from
dc081b4 to
518a099
Compare
zenlex
approved these changes
Feb 23, 2024
zenlex
pushed a commit
that referenced
this pull request
Apr 27, 2024
* chore: add/configure formatter * style: format * chore: revert to whole-file format on save * Revert "style: format" This reverts commit 06525d5. * chore: pin dependencies * chore: add TS style guide Pulled from https://github.com/Expensify/App * chore: add explicit typescript dependency * chore: allow comments in tsconfig TS doesn't choke on comments in tsconfig.json * style: make tsconfig slightly more strict * chore: customize TYPESCRIPT.md - removed referencces to expensify - removed/fixed parts that were irrelevent to this project - added 'single source of truth' file for globals/module augmentation * style: udpate prettier to use tabs, single quotes Also removes redundant options that were previously explicit see: https://techlahoma.slack.com/archives/C061ADYPHNJ/p1708476318174819 * chore: cleanup prettier config * style: enable type acquisition * chore: remove temp comments * chore: fix typos in tsconfig/settings.json * chore: add linter dependencies * chore: configure eslint for unicorn/airbnb * chore: force using npm as package manager * chore: revert to spaces over tabs tabs reached consensus based on the misconception that 1 tab is 2 spaces * chore: add eslint extension to recommendations * chore: fix type errors, refine tsconfig * chore: add eslint script * chore: exclude node_modules from type checking * chore: add unicorn, fix lint config + eslint types * chore: refine eslint config, fix errors * chore: pin deps * chore: update workspace recommendations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds prettier, along with a an opinionated configuration. The exact config isn't necessarily set in stone, but you can see the difference in here
If everyone is okay with this config I can revert the commit that applies the formatting and commit the config and the formatting results as separate PRs
Edit: This PR also adds and configures TypeScript and TypeScript-ESLint