Fixing NaN endPoint Issue Causing Extra Lines in Marker Drawing #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes, additional lines appear on the screen while I'm drawing. This is often caused by the endPoint becoming NaN in some cases. By implementing a check for isNaN, this issue is resolved.
revert version update
tugcearar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to resolve an issue where extra lines appear on the screen during the drawing process with marker. The problem stems from situations where the endPoint value becomes NaN. To mitigate this, the proposed solution involves implementing a check for isNaN before processing the endPoint.
Changes Made:
Introduced a conditional check for NaN values in the endPoint.
Added validation to ensure that only valid numerical values are used for drawing, preventing unexpected artifacts.
Screenshot and video:
RPReplay_Final1693468671.mov
Thank you for reviewing this pull request. Your feedback is essential in ensuring the quality and functionality of the codebase.