Improve legacy photo post special handling #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirreal
had a problem deploying
to
integration-suite
GitHub Actions
Error
sirreal
temporarily deployed
to
integration-suite
GitHub Actions
Inactive
straku
reviewed
Aug 16, 2023
lib/tumblr.js
Outdated
| pathParts[2].toLowerCase() === 'blog' && | ||
| pathParts[4].toLowerCase() === 'post' && | ||
| // Make sure there's nothing after optional trailing `/` | ||
| !pathParts[5]; |
There was a problem hiding this comment.
Minor feedback: I scratched my head a little bit over the last condition. It's smart, but maybe we could simplify it by normalizing pathname (making sure that the one that we analyze doesn't have trailing /) before doing the checks?
const pathname = url.pathname.endsWith('/') ? url.pathname.slice(0, -1) : url.pathname;
const pathParts = pathname.split('/');
...
straku
approved these changes
Aug 16, 2023
sirreal
force-pushed
the
improve-legacy-photo-post-match
branch
from
b17f15d
to
dfa8ec6
Compare
sirreal
had a problem deploying
to
integration-suite
GitHub Actions
Failure
sirreal
had a problem deploying
to
integration-suite
GitHub Actions
Failure
sirreal
temporarily deployed
to
integration-suite
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Legacy photo posts require some special handling. Improve matching logic for legacy photo posts.