Add linting and acceptance test workflow

.github/workflows/10-test-lint.yaml

@@ -0,0 +1,43 @@
+name: "10 - Test: Linting"
+on:
+  push:
+    tags:
+      - v*
+    branches:
+      - main
+      - "v*"
+  workflow_dispatch:
+  pull_request:
+
+jobs:
+  golangci:
+    name: Test Linting
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout Tailpipe plugin SDK repository
+        uses: actions/checkout@v4
+        with:
+          repository: turbot/tailpipe-plugin-sdk
+          path: tailpipe-plugin-sdk
+          token: ${{ secrets.GH_ACCESS_TOKEN }}
+
+      - name: Checkout Pipe Fittings Components repository
+        uses: actions/checkout@v4
+        with:
+          repository: turbot/pipe-fittings
+          path: pipe-fittings
+          ref: tp
+
+      # this is required, check golangci-lint-action docs
+      - uses: actions/setup-go@v5
+        with:
+          go-version: '1.23'
+          cache: false # setup-go v4 caches by default, do not change this parameter, check golangci-lint-action doc: https://github.com/golangci/golangci-lint-action/pull/704
+
+      - name: golangci-lint
+        uses: golangci/golangci-lint-action@v6
+        with:
+          version: v1.61.0
+          args: --timeout=10m
+          working-directory: tailpipe-plugin-sdk
+          skip-cache: true

.github/workflows/11-test-acceptance.yaml

@@ -0,0 +1,49 @@
+name: "11 - Test: Acceptance"
+on:
+  workflow_call:
+  push:
+    tags:
+      - v*
+    branches:
+      - main
+  workflow_dispatch:
+  pull_request:
+
+env:
+  TAILPIPE_UPDATE_CHECK: false
+  SPIPETOOLS_TOKEN: ${{ secrets.SPIPETOOLS_TOKEN }}
+
+jobs:
+  goreleaser:
+    name: Build
+    runs-on: ubuntu-latest
+    steps:
+
+      - name: Checkout Pipe Fittings Components repository
+        uses: actions/checkout@v4
+        with:
+          repository: turbot/pipe-fittings
+          path: pipe-fittings
+          ref: tp
+
+      - name: Checkout Tailpipe plugin SDK repository
+        uses: actions/checkout@v4
+        with:
+          repository: turbot/tailpipe-plugin-sdk
+          path: tailpipe-plugin-sdk
+          token: ${{ secrets.GH_ACCESS_TOKEN }}
+          ref: develop
+
+       # this is required, check golangci-lint-action docs
+      - uses: actions/setup-go@v5
+        with:
+          go-version: '1.23'
+          cache: false # setup-go v4 caches by default, do not change this parameter, check golangci-lint-action doc: https://github.com/golangci/golangci-lint-action/pull/704
+
+      - name: Run CLI Unit Tests
+        run: |
+          cd tailpipe-plugin-sdk
+          go clean -testcache
+          go test -timeout 30s ./... -test.v
+
+# TODO - add SDK acceptance tests

.golangci.yml

@@ -0,0 +1,42 @@
+linters:
+  disable-all: true
+  enable:
+    # default rules
+    - errcheck
+    - gosimple
+    - govet
+    - ineffassign
+    - staticcheck
+    - typecheck
+    - unused
+    # other rules
+    - asasalint
+    - asciicheck
+    - bidichk
+    - durationcheck
+    - exportloopref
+    - forbidigo
+    - gocritic
+    - gocheckcompilerdirectives
+    - gosec
+    - makezero
+    - nilerr
+    - nolintlint
+    - reassign
+    - sqlclosecheck
+    - unconvert
+
+linters-settings:
+  nolintlint:
+    require-explanation: true
+    require-specific: true
+
+  gocritic:
+    disabled-checks:
+      - ifElseChain       # style
+      - singleCaseSwitch  # style & it's actually not a bad idea to use single case switch in some cases
+      - assignOp          # style
+      - commentFormatting # style
+
+run:
+  timeout: 5m

artifact_source/artifact_source_impl.go

@@ -277,7 +277,7 @@ func (a *ArtifactSourceImpl[S, T]) OnArtifactDownloaded(ctx context.Context, inf
 }
 
 func (a *ArtifactSourceImpl[S, T]) GetTiming() types.TimingCollection {
-	return types.TimingCollection{a.DiscoveryTiming, a.DownloadTiming, a.ExtractTiming}
+	return types.TimingCollection{a.DiscoveryTiming, a.DownloadTiming, a.ExtractTiming} //nolint: govet // TODO Timing contains sync.Mutex, find a nice way of handling this
 }
 
 // convert a downloaded artifact to a set of raw rows, with optional metadata
@@ -287,6 +287,9 @@ func (a *ArtifactSourceImpl[S, T]) processArtifact(ctx context.Context, info *ty
 	slog.Debug("RowSourceImpl processArtifact", "artifact", info.Name)
 
 	executionId, err := context_values.ExecutionIdFromContext(ctx)
+	if err != nil {
+		return err
+	}
 	// load artifact data
 	// resolve the loader - if one has not been specified, create a default for the file tyoe
 	loader, err := a.resolveLoader(info)