Rory Magee #197
Rory Magee #197
Conversation
There was a problem hiding this comment.
@roryemagee1 - Hi Rory, I just had a chance to go over your pre-work and you are officially Turing ready. I added in some questions/comments to a few sections for areas to work on or adjustments to make before starting Mod 1 - I would especially recommend reviewing the pre-teaching gist, I noticed that was incomplete. Let me know if you have any questions.
finalPrep/README.md
Outdated
|
|
||
| When you are finished, add screenshots of your calendar so we can provide feedback if needed! | ||
|
|
||
| - `Add Week 1 Screenshot Here` | ||
| -  | ||
| - `Add Week 2 Screenshot Here` | ||
| - `Add Week 3 Screenshot Here` |
There was a problem hiding this comment.
Where are your Week 2 and 3 screenshots?
finalPrep/README.md
Outdated
| - [ ] Complete the [Pre Teaching Practice exercise](https://gist.github.com/ericweissman/0036e8fe272c02bd6d4bb14f42fd2f79) gist | ||
| - [ ] Add a link to your gist here: | ||
| - [X] Complete the [Pre Teaching Practice exercise](https://gist.github.com/ericweissman/0036e8fe272c02bd6d4bb14f42fd2f79) | ||
| - [X] Add a link to your gist here: https://gist.github.com/roryemagee1/5722b29eb204f53cf318c14a444fd2e5/edit |
There was a problem hiding this comment.
The link you posted here is incorrect - takes me to a 404 page (page not found). When I remove the /edit it works, but it also appears your gist has not been completed.
| } else if (i % num2 === 0) { // This if else statement checks whether the remainder of i/num2 is absolutely equal to 0, meaning i is divisible by num2. | ||
| console.log('buzz'); // If i is divisible by num2, the previous if else statement evaluates as true, and the console outputs the string "buzz". | ||
| } else { // If the previous if else statement evaluates as false, the loop moves onto the else statement, which logs the variable i as it is currently defined. | ||
| console.log(i); // Each time the program evaulates the if or if else or else statements as true or false, the program cycles back to the beginning, and continues until the for loop evaluates as false. |
There was a problem hiding this comment.
Nice work on your annotations. No need to update here, but something to consider as you continue practicing - it can get especially difficult to read through annotations/comments when they're on the same line as the code they're describing - I usually break mine out into chunks above the code to make it more readable.
finalPrep/modZeroHero.js
Outdated
| // Print the last archEnemy to the console | ||
|
|
||
| console.log(archEnemies[2]); |
There was a problem hiding this comment.
How would you print the last archEnemy to the console if you didn't know the length of the array?
finalPrep/modZeroHero.js
Outdated
| // - badExcuse should be a string a hero would say if they are too afraid of the dangerLevel | ||
|
|
||
| var dangerLevel = 101; |
There was a problem hiding this comment.
No need to declare these variables - the function simply accepts 3 arguments called dangerLevel, saveTheDay, and badExcuse - they're placeholders for when you invoke the function with the actual arguments.
| @@ -44,7 +90,7 @@ | |||
| //Test Cases | |||
| var announcement = 'Never fear, the Courageous Curly Bracket is here!'; | |||
| var excuse = 'I think I forgot to lock up my 1992 Toyota Coralla. Be right back.'; | |||
| // assessSituation(99, announcement, excuse) > Should print - 'I think I forgot to lock up my 1992 Toyota Coralla. Be right back.' | |||
There was a problem hiding this comment.
Here is where the function is invoked and three arguments passed in.
finalPrep/modZeroHero.js
Outdated
| weight: 200, | ||
| citiesDestroyed: ["Metropolis", "Gotham"], | ||
| luckyNumbers: [13, 666], | ||
| address: { number: 666, street: "Weird Walkway", state: "Anti-Delaware", zip: 66666 }, |
There was a problem hiding this comment.
It's best to format objects with key/value pairs on separate lines, like so:
address: {
number: 666,
street: "Weird Walkway",
state: "Anti-Delaware",
zip: 66666
}
| } | ||
|
|
||
| gainPower(powerLevel) { | ||
| this.powerLevel = this.powerLevel + powerLevel |
Fix calendar screenshots
Fix gist link
No description provided.