Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Casey Halstead #200

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Casey Halstead #200

wants to merge 18 commits into from

Conversation

chalstead16
Copy link

No description provided.

Copy link
Collaborator

@kaitvan kaitvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Casey, I reviewed your prework and you are officially turing ready! I added some comments to a few sections for areas to work on or adjustments to make before starting Mod 1. I appreciate all of your hard work up to this point. Definitely let me know if you have any questions.

// - badExcuse should be a string a hero would say if they are too afraid of the dangerLevel

function assessSituation() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your function should only be declared once. Here, you can list the variables with their assigned values, but you want the function that you declared on line 73.

function assessSituation(dangerLevel, saveTheDay, badExcuse){
if(dangerLevel >50){
console.log(badExcuse);
} else if(dangerLevel >= 10 && dangerLevel >=50){
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Excepts on line 76, you've already checked that dangerLevel is greater than 50, so you only need to check if dangerLevel is > 9 instead of checking both. This works though!

// - energyLevel = 50
// - energyLevel = 50

class SuperHero {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lowercase first letter, so class superHero {

@@ -2,41 +2,66 @@
// Use the double // to create a new comment

//Build a Bear
//declaring a function with 5 parameters
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love all of the precise vocabulary you included in your annotations!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants