Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nathan Hodnett #202

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Nathan Hodnett #202

wants to merge 5 commits into from

Conversation

nhodnett
Copy link

@nhodnett nhodnett commented Nov 2, 2021

No description provided.

Copy link
Collaborator

@kaitvan kaitvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Nathan, I reviewed your prework and you are officially turing ready! I added some comments to a few sections for areas to work on or adjustments to make before starting Mod 1, but they are just for you and I won't be checking up on them. Keep up the hard work moving forward and let me know if you have any questions!

// Declare two variables - fullPower AND fullEnergy
// fullPower should multiply your current power by 500
// fullEnergy should add 150 to your current energy

var fullPower = (power) * 500;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for the parenthesis here, but they're not hurting anything either.


if (dangerLevel > 50) {
console.log(badExcuse);
} else if (dangerLevel >= 10 && dangerLevel <= 50) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be simplified to only check for dangerLevel greater than 9, since line 52 already checks for values greater than 50. But it works either way!

number: 13,
street: "Evil Street",
state: "FL",
zip:30315};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually I would keep this closing curly bracket on the next line without a semicolon after it.


// What skills do you need to continue to practice before starting Mod 1?

//Functions, classes, class methods...
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll definitely get more practice with these concepts in Mod 1. You don't have to 100% understand this stuff yet.

// Declare two variables - greeting AND catchphrase
// greeting should be assigned to a string that uses concatenation to include the heroName
// catchphrase should be assigned to a string that uses interpolation to include the specialAbility

var greeting = "Hi! You're safe now!";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These directions wanted you to show how to use both concatenation and interpolation. I saw other examples of this throughout the rest of your work though!

console.log("I have enough money for a gumball");
} else if (numQuarters < 2) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could just use else here without checking another condition since any number of quarters less than 2 won't pass the first condition.

@nhodnett
Copy link
Author

nhodnett commented Nov 4, 2021

Thanks Kaitlyn! Very excited... I will 100% review your comments. I feel particularly stupid about the one where I missed concatenation or interpolation... 🙄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants