Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jerry Vohrer #212

Open
wants to merge 42 commits into
base: main
Choose a base branch
from
Open

Jerry Vohrer #212

wants to merge 42 commits into from

Conversation

Jerry-Vrrr
Copy link

Here is my finished M1 Pre-work!

@cowens87
Copy link

cowens87 commented Nov 16, 2021

Hey Jerry, I reviewed your pre-work and I would like you to make some changes before we can consider you officially Turing ready. I added some comments to a few sections for areas to make adjustments before starting Mod 1 Additionally, I was unable to find you on the prework/gear up submission form, so I was unable to review your gear up. Please review the instructions for submission and submit your gearup and prework links. Please have changes made and submitted by 12p MST tomorrow and Kaitlyn will follow up with you. Please let me know if you have any questions.

@Jerry-Vrrr
Copy link
Author

Jerry-Vrrr commented Nov 17, 2021

Hey Jerry, I reviewed your pre-work and I would like you to make some changes before we can consider you officially Turing ready. I added some comments to a few sections for areas to make adjustments before starting Mod 1 Additionally, I was unable to find you on the prework/gear up submission form, so I was unable to review your gear up. Please review the instructions for submission and submit your gearup and prework links. Please have changes made and submitted by 12p MST tomorrow and Kaitlyn will follow up with you. Please let me know if you have any questions.

Not sure what happened with the gear up link, but I will review all instructions, your comments and re-submit by 12pm. Thanks.

@Jerry-Vrrr
Copy link
Author

I just noticed 4pm on the original comment changed to 12pm. Shouldn't be a problem, but to speed up the process, I have one question. I assume that the comments are in the code itself as "// comments". I didn't see any in my initial sweep earlier this morning. I will more thoroughly look now that I have more time, but if I am looking in the wrong place, I would love a hint as to where the comments and adjustments may be for time sake.

As far as the Gear up, it was not public, but I have made the correction and will make sure it is resubmitted properly with everything else. Here is a direct link to that Gear up.
https://gist.github.com/Jerry-Vrrr/3da1f663c1ce1909f7795cf658d284a2

Thanks!

@Jerry-Vrrr
Copy link
Author

I pulled to get any recent changes. I went back in to each section. I also looked at commits to see if anyone else committed changes, but there was nothing. I will be in orientation until the new 12pm deadline, so I will re-submit the pull request during the next break.

@Jerry-Vrrr
Copy link
Author

Still awaiting a response on whether I am on my way to Mod-1 or if there are changes needed to my pre-work.

Copy link
Collaborator

@kaitvan kaitvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Jerry. Take a look at my comments!

var heroName = "Velvet Mummy";
var specialAbility = "dance fighting";
console.log(heroName);
console.log(specialAbility);

// Declare two variables - greeting AND catchphrase
// greeting should be assigned to a string that uses concatenation to include the heroName
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure you read the directions carefully. The variable greeting should use concatenation with the heroName and catchPhrase should use interpolation with the specialAbility.


function assessSituation() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The three arguments dangerLevel, saveTheDay, and badExcuse go between the parenthesis after the name of your function as placeholders. You will pass in the actual values as parameters when you call the function.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, you can test your code by running it in a replit. If you did that, you would quickly realize that this function doesn't work!

@@ -55,30 +91,66 @@ var excuse = 'I think I forgot to lock up my 1992 Toyota Coralla. Be right back.
// - citiesDestroyed (array)
// - luckyNumbers (array)
// - address (object with following key/values: number , street , state, zip)


var scaryMonster = {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The syntax for this object looks good.

}

}
var maximizeEnergy = (energyLevel = 1000)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Methods are essentially functions that live inside that class. This syntax is wrong, but we can update it together when we meet.

Copy link
Collaborator

@kaitvan kaitvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Jerry. I reviewed your prework and you are officially turing ready! Thank you for making those changes we talked about. Keep up the hard work moving forward and let me know if you have any questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants