Complete initial pass on virtual tables #858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PThorpe92
commented
Feb 2, 2025
PThorpe92
commented
Feb 2, 2025
PThorpe92
force-pushed
the
virtual-tables
branch
2 times, most recently
from
f2a29bb to
4ff4c6d
Compare
PThorpe92
commented
Feb 3, 2025
PThorpe92
force-pushed
the
virtual-tables
branch
2 times, most recently
from
163e73d to
53d227f
Compare
PThorpe92
force-pushed
the
virtual-tables
branch
2 times, most recently
from
6a95e34 to
b3cc7b5
Compare
jussisaurio
reviewed
Feb 5, 2025
core/translate/planner.rs
Outdated
| Ok(TableReference { | ||
| op: Operation::Scan { iter_dir: None }, | ||
| join_info: None, | ||
| table: Table::Virtual(vtab.clone().into()), |
There was a problem hiding this comment.
wonder if we could get rid of enum TableReferenceType if Table::Virtual had the args in it. Semantically it sort of fits I think, generate_series(1,10,1) is an instantiation of generate_series with those arguments. but mainly I'm just looking for excuses not to have TableReferenceType anymore :)
There was a problem hiding this comment.
gahhh I swear was wondering about that I almost just removed it. Yeah I think it is, and it applies in the case of other examples I am thinking of
There was a problem hiding this comment.
ok that wasn't so bad 👍
PThorpe92
changed the title
PThorpe92
force-pushed
the
virtual-tables
branch
from
b7bee6f to
eb06cfa
Compare
PThorpe92
force-pushed
the
virtual-tables
branch
from
eb06cfa to
ae88d51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT:
Ok this should finally be all set. There were some massive changes that had taken place since the original PR 🫠 🫠 merge conflicts were serious
As soon as this is merged, I will finish the rest of what is needed for
CREATE VIRTUAL TABLE some_table USING some_extension('some argument or sql');I added tests for the series extension.
This PR is already big and covers a LOT of surface area, so we should ideally try to get this in first, and I'll go back and complete the rest of the functionality 👍