Skip to content

Commit

Permalink
[Inji-327] fix something went wrong error which is coming when user c…
Browse files Browse the repository at this point in the history
…licks on resend code during the vc activation (mosip#1177)

* [INJI-327] call binding-otp api of esignet instead of otp api of resident services when user clicks on resend code

Signed-off-by: PuBHARGAVI <[email protected]>

* [INJI-327] remove duplicate code in existing and esignet vc item machines

Signed-off-by: PuBHARGAVI <[email protected]>

* [INJI-327] remove duplicates & use common selectors for both kebab popup and detailed view of vc

Signed-off-by: PuBHARGAVI <[email protected]>

* [INJI-327] change walletBindingIdResponseForPrivateUpdateKey to tempWalletBindingIdResponse for better meaning

Signed-off-by: PuBHARGAVI <[email protected]>

* [INJI-327] remove redundant telemetry activation success event call in esignet vc item machine

Signed-off-by: PuBHARGAVI <[email protected]>

* [INJI-327] send telemetry event when vc activation fails due to private key updation failure

Signed-off-by: PuBHARGAVI <[email protected]>

* [INJI-327] extract common actions of updating private key and wallet binding id into seperate state

Signed-off-by: PuBHARGAVI <[email protected]>

---------

Signed-off-by: PuBHARGAVI <[email protected]>
  • Loading branch information
PuBHARGAVI authored Jan 23, 2024
1 parent a31e2d3 commit ee2b07a
Show file tree
Hide file tree
Showing 9 changed files with 362 additions and 674 deletions.
12 changes: 7 additions & 5 deletions .talismanrc
Original file line number Diff line number Diff line change
Expand Up @@ -55,14 +55,16 @@ fileignoreconfig:
checksum: adbc2ff6df1df412e891c988c9ba03fc82f66c2f6c64339f87d513fc835d14cc
- filename: machines/store.typegen.ts
checksum: 6d22bc5c77398316b943c512c208ce0846a9fff674c1ccac79e07f21962acd5f
- filename: machines/VCItemMachine/ExistingMosipVCItem/ExistingMosipVCItemMachine.typegen.ts
checksum: 10889302ca05646a283386be1bbe7a5fb510c02bb62a308ee45f3c2a872ae64e
- filename: shared/telemetry/TelemetryConstants.js
checksum: 9d9acf3981cbde452489eacbbd70ebaa0b853c1c04e9712fa71368c089a9662b
checksum: df7619021aa023fa62ade9efb60a80fc9c6901da8c52f563014d3f51497c190c
- filename: machines/VCItemMachine/EsignetMosipVCItem/EsignetMosipVCItemMachine.ts
checksum: cca7657da3a1a91b63e0a10605545d1e0d3d152b083a55f9dbb9eed893646e4b
- filename: machines/VCItemMachine/ExistingMosipVCItem/ExistingMosipVCItemMachine.ts
checksum: 8bc83e91cd46caedfd99bf5e7c5f729f455da5556dc551e820dc4615ebb6eb76
- filename: machines/VCItemMachine/EsignetMosipVCItem/EsignetMosipVCItemMachine.typegen.ts
checksum: 15308987b1aab0c51c96bfc646ae55a3d7ae728a1f6e03ab31d5e1b786da03eb
checksum: 0de47337ba60b29c8e4d4231439c77028197d3d8d3139eb367c471138c40f93d
- filename: machines/VCItemMachine/ExistingMosipVCItem/ExistingMosipVCItemMachine.typegen.ts
checksum: 533785a3c8096ea93afc59c65025679c24d379e824e784e745ab298a0978cd2a
checksum: 86ecb95b58456d42676247eb768a7fba980a3c0ef83d515f8b9ce0c44d8c6906
- filename: shared/telemetry/TelemetryUtils.js
checksum: a0686e9a5c006176fd720b84bc36ca947db1422caf65c90cd0c2d1102a9e96df
- filename: ios/fastlane/Fastfile
Expand Down
15 changes: 6 additions & 9 deletions components/KebabPopUpController.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@ import {
selectEmptyWalletBindingId,
selectIsPinned,
selectKebabPopUp,
selectKebabPopUpAcceptingBindingOtp,
selectKebabPopUpBindingWarning,
selectKebabPopUpWalletBindingInProgress,
selectAcceptingBindingOtp,
selectBindingWarning,
selectWalletBindingInProgress,
selectOtpError,
selectRemoveWalletWarning,
selectShowActivities,
Expand Down Expand Up @@ -48,12 +48,9 @@ export function useKebabPopUp(props) {
const INPUT_OTP = (otp: string) => service.send(vcEvents.INPUT_OTP(otp));
const RESEND_OTP = () => service.send(vcEvents.RESEND_OTP());
const isPinned = useSelector(service, selectIsPinned);
const isBindingWarning = useSelector(service, selectKebabPopUpBindingWarning);
const isBindingWarning = useSelector(service, selectBindingWarning);
const isRemoveWalletWarning = useSelector(service, selectRemoveWalletWarning);
const isAcceptingOtpInput = useSelector(
service,
selectKebabPopUpAcceptingBindingOtp,
);
const isAcceptingOtpInput = useSelector(service, selectAcceptingBindingOtp);
const isWalletBindingError = useSelector(
service,
selectShowWalletBindingError,
Expand All @@ -66,7 +63,7 @@ export function useKebabPopUp(props) {
);
const WalletBindingInProgress = useSelector(
service,
selectKebabPopUpWalletBindingInProgress,
selectWalletBindingInProgress,
);
const emptyWalletBindingId = useSelector(service, selectEmptyWalletBindingId);
const isKebabPopUp = useSelector(service, selectKebabPopUp);
Expand Down
Loading

0 comments on commit ee2b07a

Please sign in to comment.