Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destroy connection on transfer complete #26

Merged
merged 2 commits into from
Feb 28, 2023

Conversation

shreeThaanuTw
Copy link

@shreeThaanuTw shreeThaanuTw commented Feb 27, 2023

What?

To destroy the connection when the UI response captured from User on success / failure

Why?

To remove the peripheral and make the device ready for next connection

How?

Added is selfdisconnect and trigger it when the emitter responds

Testing?

  1. Disconnection on successful VC transfer
  2. Disconnection on closing Verifier/Wallet app
  3. Disconnection on clicking cancel button on Verifier
  4. Disconnection on Accepting/Discarding/Reject VC

Anything Else?

Issue Link : mosip/inji-wallet#593

@shreeThaanuTw shreeThaanuTw self-assigned this Feb 27, 2023
Copy link

@vharsh vharsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Alka1703 Alka1703 merged commit 3e5424c into develop Feb 28, 2023
shreeThaanuTw pushed a commit that referenced this pull request Mar 3, 2023
Improve VC Transfer Stability for iOS and Android
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants