Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing ValueUtils.hs #437

Merged
merged 4 commits into from
Jul 18, 2024
Merged

Removing ValueUtils.hs #437

merged 4 commits into from
Jul 18, 2024

Conversation

mmontin
Copy link
Collaborator

@mmontin mmontin commented Jul 17, 2024

This is mean to remove ValueUtils.hs.
This closes #399
This also closes #255

@mmontin
Copy link
Collaborator Author

mmontin commented Jul 18, 2024

For now, it relies on a fork of cardano-node-emulator. I will have it ready for review once CNE is updated and we can rely on it directly.

@mmontin mmontin requested a review from florentc July 18, 2024 09:38
@mmontin mmontin marked this pull request as ready for review July 18, 2024 09:39
@mmontin mmontin merged commit da69805 into main Jul 18, 2024
3 checks passed
@mmontin mmontin deleted the mm/no-value-utils branch July 18, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florentc florentc florentc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get rid of ValueUtils Get rid of the hack to retrieve private keys in Cooked.Wallet.walletStakingSK
2 participants
@mmontin @florentc