-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR3: Tweaks around inputs and outputs restructured, with an additional tweak #458
Conversation
91364d9
to
00d2649
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO This greatly improves the organization of the tweaks by fitting the same structure as a skeleton and its fields.
Since modifySpendRedeemersOfTypeTweak
is, quite naturally, introduced in Tweak.Inputs
, maybe the tweaks in TamperDatum
should belong in Outputs
from now on?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like smaller files 🙂 nothing much to add otherwise.
@florentc having the datum tampering in the outputs makes complete sense thanks for the suggestion. I'll add it right away in this PR. |
This PR introduces a few changes around tweaks and outputs: