Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR3: Tweaks around inputs and outputs restructured, with an additional tweak #458

Merged
merged 14 commits into from
Feb 26, 2025

Conversation

mmontin
Copy link
Collaborator

@mmontin mmontin commented Feb 14, 2025

This PR introduces a few changes around tweaks and outputs:

  • A new tweak is introduced to modify certain spend redeemers based on their type
  • Tweaks revolving around inputs, outputs and mint have been separated into their own files
  • Tweaks revolving around tampering the datum have been put into output tweaks
  • Outputs now have setters for their various fields

@mmontin mmontin changed the base branch from main to mm/txoutref-to-txskelout February 14, 2025 18:46
@mmontin mmontin force-pushed the mm/txoutref-to-txskelout branch from 91364d9 to 00d2649 Compare February 14, 2025 22:46
Copy link
Member

@florentc florentc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO This greatly improves the organization of the tweaks by fitting the same structure as a skeleton and its fields.

Since modifySpendRedeemersOfTypeTweak is, quite naturally, introduced in Tweak.Inputs, maybe the tweaks in TamperDatum should belong in Outputs from now on?

Copy link
Member

@yannham yannham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like smaller files 🙂 nothing much to add otherwise.

@mmontin
Copy link
Collaborator Author

mmontin commented Feb 26, 2025

@florentc having the datum tampering in the outputs makes complete sense thanks for the suggestion. I'll add it right away in this PR.

Base automatically changed from mm/txoutref-to-txskelout to main February 26, 2025 17:27
@mmontin mmontin merged commit 9daeb5e into main Feb 26, 2025
7 checks passed
@mmontin mmontin deleted the mm/tweaks-input-outputs-restructured branch February 26, 2025 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants