Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Compile on GHC 9.6.2 #5

Closed
wants to merge 1 commit into from
Closed

Conversation

seanhess
Copy link
Contributor

@seanhess seanhess commented Jul 28, 2023

Fixes #4

* is deprecated in favor of Type
Functor is now a prerequisite for Bifunctor

Let me know if anything needs to be changed! Thanks for your hard work on this.

* is deprecated in favor of Type
Functor is now a prerequisite for Bifunctor
@GuillaumeDesforges
Copy link

Hi @seanhess , thanks a lot for pushing this fix!

The changes look reasonable to me. 👍

If possible I would prefer to have atomic commits. Can we make the fix of #4 and the changes from * to Type to be two different PRs, or at least two commits?

@GuillaumeDesforges GuillaumeDesforges changed the title Bugfix: Compile on GHC 9.6.2. Resolves #4 Bugfix: Compile on GHC 9.6.2 Aug 1, 2023
@GuillaumeDesforges GuillaumeDesforges added the bug Something isn't working label Aug 1, 2023
@seanhess
Copy link
Contributor Author

seanhess commented Aug 2, 2023

Sure, I'd be happy to do that. Should have them in a few minutes. Although, to play devil's advocate, they are both fixes that were necessary to get it to compile with 9.6.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GHC 6, base 4.18 support - Could not deduce Functor
2 participants