Add some git utilities #2095
Merged
Add some git utilities #2095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bencher Report| Branch | npm-git |
| Testbed | ubuntu-latest |
Click to view all benchmark results
| Benchmark | Latency | nanoseconds (ns) |
|---|---|---|
| fibonacci 10 | 📈 view plot 🚷 view threshold | 498,490.00 |
| foldl arrays 50 | 📈 view plot 🚷 view threshold | 1,658,000.00 |
| foldl arrays 500 | 📈 view plot 🚷 view threshold | 6,597,400.00 |
| foldr strings 50 | 📈 view plot 🚷 view threshold | 7,147,800.00 |
| foldr strings 500 | 📈 view plot 🚷 view threshold | 62,143,000.00 |
| generate normal 250 | 📈 view plot 🚷 view threshold | 46,087,000.00 |
| generate normal 50 | 📈 view plot 🚷 view threshold | 2,074,800.00 |
| generate normal unchecked 1000 | 📈 view plot 🚷 view threshold | 3,432,500.00 |
| generate normal unchecked 200 | 📈 view plot 🚷 view threshold | 767,210.00 |
| pidigits 100 | 📈 view plot 🚷 view threshold | 3,252,600.00 |
| pipe normal 20 | 📈 view plot 🚷 view threshold | 1,503,800.00 |
| pipe normal 200 | 📈 view plot 🚷 view threshold | 10,571,000.00 |
| product 30 | 📈 view plot 🚷 view threshold | 834,060.00 |
| scalar 10 | 📈 view plot 🚷 view threshold | 1,537,400.00 |
| sum 30 | 📈 view plot 🚷 view threshold | 838,870.00 |
yannham
approved these changes
Nov 15, 2024
git/src/lib.rs
Outdated
| .wrap_err()? | ||
| // For now, we always fetch shallow. Maybe for the index it's more efficient to | ||
| // keep a single repo around and update it? But that might be in another method. | ||
| .with_shallow(gix::remote::fetch::Shallow::DepthAtRemote( |
There was a problem hiding this comment.
Nitpick: there are a lot of gix::remote::fetch:: prefixes. Maybe it would be worth importing at least fetch, or even a few symbols directly?
| std::fs::create_dir_all(dir).with_path(dir)?; | ||
|
|
||
| // Fetch the git directory somewhere temporary. | ||
| let git_tempdir = tempfile::tempdir().wrap_err()?; |
There was a problem hiding this comment.
Maybe a naive question, but why do we need a temporary directory first? Can't we do everything in dir directly?
There was a problem hiding this comment.
We need to put the .git stuff somewhere. There's probably no harm in putting it in dir, but I thought it was cleaner to just populate dir with the contents, and not the .git stuff.
There was a problem hiding this comment.
Oh, you can choose to put the git stuff separately, I see. That's fine by me 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a mini-crate with some git-related utilities. It's split off from the main packaging PR, and doesn't interact with anything else.