refactor darwin CC toolchain to work with nixpkgs 24.11 #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malt3
force-pushed
the
mp/darwin-new-sdk
branch
9 times, most recently
from
440a0e6 to
03fba0e
Compare
Nix completely overhauled how Apple SDKs are packaged and made available to compilers: https://discourse.nixos.org/t/the-darwin-sdks-have-been-updated/55295/27 This commit introduces a separate `pkgs.wrapCCWith` for new `apple-sdk` packages. Also removes postLinkSignHook from most places, since this is no longer an input for cc in Nix. Fixes #623
The Go standard library uses cgo with `#include <libresolv.h>`. This header is now part of `pkgs.darwin.libresolvHeaders`.
nix 2_18 is no longer available via nixpkgs in 24.11
zlib 1.3 cannot be built with clang 19 and macOS SDK 11. Upating the vendored zlib to the latest version resolves this issue. This patch can be dropped once the following upstream issue is solved: bazelbuild/bazel#25124
rules_java builds native C code (zlib) as part of the toolchains //java_tools/zlib:zlib
malt3
force-pushed
the
mp/darwin-new-sdk
branch
from
03fba0e to
b66d712
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #623