Fix for kostaskougios#105

tweimer · Jul 17, 2021 · 84859d5 · 84859d5
1 parent 0ac1457
commit 84859d5
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/src/main/java/com/rits/cloning/Cloner.java b/src/main/java/com/rits/cloning/Cloner.java
@@ -578,15 +578,17 @@ private class CloneObjectCloner implements IDeepCloner {
 			do {
 				Field[] fs = sc.getDeclaredFields();
 				for (final Field f : fs) {
-					if (!f.isAccessible()) {
-						f.setAccessible(true);
-					}
 					int modifiers = f.getModifiers();
 					if (!Modifier.isStatic(modifiers)) {
 						if (!(nullTransient && Modifier.isTransient(modifiers)) && !isFieldNullInsteadBecauseOfAnnotation(f)) {
 							l.add(f);
 							boolean shouldClone = (cloneSynthetics || !f.isSynthetic()) && (cloneAnonymousParent || !isAnonymousParent(f));
 							shouldCloneList.add(shouldClone);
+							if (shouldClone) {
+								if (!f.isAccessible()) {
+									f.setAccessible(true);
+								}
+							}
 						}
 					}
 				}

diff --git a/src/test/java/com/rits/tests/cloning/TestCloner.java b/src/test/java/com/rits/tests/cloning/TestCloner.java
@@ -908,5 +908,11 @@ public void testLinkedHashSetWithMitableValue() {
         assertEquals("Cloned value not equal to original object", dc, dc2);
 
     }
+
+    public void testStaticTransientMembers() {
+       class StaticTransient extends ArrayList<String> {};
+
+       cloner.deepClone(new StaticTransient());
+    }
 }