Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add npcs #51

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Add npcs #51

wants to merge 16 commits into from

Conversation

Bassics
Copy link
Member

@Bassics Bassics commented Feb 10, 2015

Add NonPlayableCharacter class and Entity class

@@ -21,6 +24,7 @@
private final ResourceManager RESOURCE_MANAGER;
private final Map MAP;
private final Player PLAYER;
private final List<Entity> ENTITIES;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Entities should be stored in the map

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also do you think we could use a set instead of a list?

@rmaes4
Copy link
Member

rmaes4 commented Feb 10, 2015

@Bassics We need to eliminate all repetition.

@rmaes4 rmaes4 added this to the Alpha milestone Feb 12, 2015
@rmaes4 rmaes4 self-assigned this Feb 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants