-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sitemap): ensure all canonical URL #4225
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
View your CI Pipeline Execution ↗ for commit 05b8350.
☁️ Nx Cloud last updated this comment at |
Size Change: 0 B Total Size: 1.12 MB ℹ️ View Unchanged
|
Paste
|
Project |
Paste
|
Branch Review |
canconical-sitemap-urls
|
Run status |
|
Run duration | 02m 00s |
Commit |
|
Committer | Kristian Antrobus |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
0
|
|
0
|
|
67
|
View all changes introduced in this branch ↗︎ |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 05b8350:
|
Paste
|
Project |
Paste
|
Branch Review |
canconical-sitemap-urls
|
Run status |
|
Run duration | 05m 57s |
Commit |
|
Committer | krisantrobus |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
0
|
|
0
|
|
125
|
View all changes introduced in this branch ↗︎ |
After reading resources further a lot of references mention that the sitemap.xml should contain all canonical urls (ends with a "/").
I noticed not all of them do in the current deployed one.
preview sitemap.xml
Before:
![image](https://private-user-images.githubusercontent.com/55083528/408700949-8274aa20-b40c-43db-9ec2-17cb4f71228f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDAwOTU1MTcsIm5iZiI6MTc0MDA5NTIxNywicGF0aCI6Ii81NTA4MzUyOC80MDg3MDA5NDktODI3NGFhMjAtYjQwYy00M2RiLTllYzItMTdjYjRmNzEyMjhmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMjAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjIwVDIzNDY1N1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTA0NWNhZmVkYjdkNDQyYmVmY2Q0OWNjYjI5ZTdhMDFjNmFmNzY0N2M1MDAzY2IwZDhkZWRhOGVkZDUwNGNjNjImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.HeB-MoqPWdYmKJxHzXHYHV1jbzT8HC-F4eBqJSVmlLQ)
![image](https://private-user-images.githubusercontent.com/55083528/408701003-e6058de2-eeb2-4512-92a2-e69d4dcc33d6.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDAwOTU1MTcsIm5iZiI6MTc0MDA5NTIxNywicGF0aCI6Ii81NTA4MzUyOC80MDg3MDEwMDMtZTYwNThkZTItZWViMi00NTEyLTkyYTItZTY5ZDRkY2MzM2Q2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMjAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjIwVDIzNDY1N1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTliZDdiODZmZjQ2MzdlMmJmMWMzMTQ3MzhlOTI3YjY0NGEzNjU5Y2ZhZmFhM2RkNTI5ZjQ0YjBlZDMxNTI4MzImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.4JHilVpzM1AcYqBOEDN0j2jVUsuDtolQGF0epdot4Bs)
After:
![image](https://private-user-images.githubusercontent.com/55083528/408701069-44838223-3cec-4479-baad-0d3f849fcda9.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDAwOTU1MTcsIm5iZiI6MTc0MDA5NTIxNywicGF0aCI6Ii81NTA4MzUyOC80MDg3MDEwNjktNDQ4MzgyMjMtM2NlYy00NDc5LWJhYWQtMGQzZjg0OWZjZGE5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMjAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjIwVDIzNDY1N1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTkyM2JjMGU4NjAxMjQyNmNiMzI1ZTdkZDZkMzE4MjI0ZTRmM2ViYjY5YzQzMWFlNjg3NTI4Y2QzZDFkYWJiYmEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.4NwtCWBfnGv9RSftE08sIgSKZhkz0vTSTxHX4Npjvm4)
![image](https://private-user-images.githubusercontent.com/55083528/408701169-42689e45-af06-4a17-874f-fdfa2fdebea2.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDAwOTU1MTcsIm5iZiI6MTc0MDA5NTIxNywicGF0aCI6Ii81NTA4MzUyOC80MDg3MDExNjktNDI2ODllNDUtYWYwNi00YTE3LTg3NGYtZmRmYTJmZGViZWEyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMjAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjIwVDIzNDY1N1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWUwMDliMzExODRiMjViMDZkMmYzOTdjMWE1Y2JjYzI2OTRkYzFmNjk1ZTQ1YmZmNDMwOTRiNjIyMTM0N2Y2NTEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.20fjhQuvwA6xhLlxOvelBAghQRrJgfybekP57EyDVsM)