Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save TF State as assets #339

Merged
merged 2 commits into from
Sep 21, 2023
Merged

Save TF State as assets #339

merged 2 commits into from
Sep 21, 2023

Conversation

ChrisAmora
Copy link
Contributor

@ChrisAmora ChrisAmora commented Sep 11, 2023

Summary

Move terraform state management to Twilio Cloud function service.

Checklist

  • Tested changes end to end
  • Updated documentation
  • Requested one or more reviewers

@ChrisAmora ChrisAmora self-assigned this Sep 11, 2023
@jared-hunter jared-hunter temporarily deployed to dev September 14, 2023 20:23 — with GitHub Actions Inactive
@jared-hunter jared-hunter temporarily deployed to dev September 14, 2023 20:23 — with GitHub Actions Inactive
@jared-hunter jared-hunter temporarily deployed to dev September 14, 2023 20:25 — with GitHub Actions Inactive
@jared-hunter jared-hunter temporarily deployed to dev September 14, 2023 20:25 — with GitHub Actions Inactive
@jared-hunter jared-hunter temporarily deployed to dev September 14, 2023 20:28 — with GitHub Actions Inactive
Copy link
Contributor

@jared-hunter jared-hunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChrisAmora - this is an excellent bit of work - i am excited to move it into the main branch. I have some thoughts for minor improvements before we do that. Please let me know what you think.

infra-as-code/state/pull_state.sh Show resolved Hide resolved
.github/workflows/terraform_deploy.yml Outdated Show resolved Hide resolved
infra-as-code/state/deploy-function/functions/deploy.js Outdated Show resolved Hide resolved
@ChrisAmora ChrisAmora force-pushed the feat/tf-assets branch 2 times, most recently from 1c9152a to 4a4ded1 Compare September 18, 2023 18:20
Copy link

@lvaladares lvaladares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we start moving the pipelines to makefile structure? need it to add serverless deploys

@ChrisAmora
Copy link
Contributor Author

can we start moving the pipelines to makefile structure? need it to add serverless deploys

Not in this PR. The objective here is to change the deployment pipeline as seamlessly as possible.

Copy link
Contributor

@jared-hunter jared-hunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great and puts us in a much better spot for improving the "import" stage!! Great work! thank you for the tweaks!

@jared-hunter jared-hunter temporarily deployed to dev September 21, 2023 16:05 — with GitHub Actions Inactive
@jared-hunter jared-hunter temporarily deployed to dev September 21, 2023 16:07 — with GitHub Actions Inactive
@jared-hunter jared-hunter merged commit 01f0cae into main Sep 21, 2023
@jared-hunter jared-hunter deleted the feat/tf-assets branch September 21, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants