Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New feature 'sip mute' for muting worker non-webrtc calls #342

Closed

Conversation

chaosloth
Copy link
Contributor

Summary

Add a mute button for non-WebRTC calls (i.e. Calls via SIP or PSTN). The default mute button requires the Voice SDK to be used as it calls the local method to mute, this plugin introduces a replacement UI button with a companion serverless function to mute the Flex worker by modifying the conference participants

Checklist

  • Tested changes end to end
  • Updated documentation
  • Requested one or more reviewers

@chaosloth
Copy link
Contributor Author

@dremin would you be so kind as to review, it's similar to the common serverless functions for conference-participant

@chaosloth chaosloth changed the title Sip mute New feature 'sip mute' for muting worker non-webrtc calls Sep 13, 2023
Copy link
Contributor

@dremin dremin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed the 'end call' button is also non-functional with a SIP phone. I think it would make a lot of sense to also address that in this feature (would need a different name), what do you think?

@dremin
Copy link
Contributor

dremin commented Sep 13, 2023

Could you also run npm run lint:fix to auto-fix and expose any further issues caught by the linter?
4 ESLint error(s) and 1 ESLint warning(s) found in pull request changed files.

@chaosloth
Copy link
Contributor Author

TY @dremin Moving to new feature "sip-support" adding above changes

@chaosloth chaosloth mentioned this pull request Sep 19, 2023
3 tasks
@chaosloth chaosloth closed this Sep 19, 2023
@chaosloth
Copy link
Contributor Author

New PR with feature #350

@chaosloth chaosloth deleted the sip-mute branch October 3, 2023 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants