Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twilio Serverless services automatic deployment with terraform #351

Closed
wants to merge 2 commits into from

Conversation

lvaladares
Copy link

@lvaladares lvaladares commented Sep 19, 2023

Summary

Provide a summary of the change

Checklist

  • Tested changes end to end
  • Updated documentation
  • Requested one or more reviewers

Copy link
Contributor

@jared-hunter jared-hunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2023-09-20 at 13 15 01

Looks like some paths are not aligned here.

Really excited to get this change in but i also want to sanity check how we reference the function resources - currently we use the CLI and inject via the action.yaml. If we can remove that need for functions that would be great.

@lvaladares
Copy link
Author

lvaladares commented Sep 20, 2023

Let me check that @jhunter-twilio. Any idea how can I trigger the pipelines for a dry/test run? actions are a bit finicky because it needs the commit to check if it's working 😢 🐔 🥚

@ChrisAmora
Copy link
Contributor

ChrisAmora commented Sep 20, 2023

Let me check that @jhunter-twilio. Any idea how can I trigger the pipelines for a dry/test run? actions are a bit finicky because it needs the commit to check if it's working 😢 🐔 🥚

One way would be to fork the template and populate with your Twilio environment variables.

@lvaladares
Copy link
Author

services folder was missing because git doesn't commit empty folders

@lvaladares
Copy link
Author

will close this and open a new pr from another fork

@lvaladares
Copy link
Author

lvaladares commented Sep 28, 2023

moved to -> #366

@lvaladares lvaladares closed this Sep 28, 2023
@lvaladares lvaladares deleted the feat/demoeng-1319-serverless-deploy branch September 28, 2023 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants