Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Worker Canvas Tabs for Skills, Channel Capacity & Worker Attributes #381

Merged
merged 29 commits into from
Jan 23, 2024

Conversation

ldvlgr
Copy link
Contributor

@ldvlgr ldvlgr commented Oct 10, 2023

Summary

This enhancement adds Tabs to the Worker Canvas for Skills, Channel Capacity & Worker Attributes.
The existing native WorkerSkills component is removed from the Worker Canvas and added as the first tab.
Supervisor Channel Capacity is moved to the 2nd tab and Worker Attributes viewer to the 3rd tab.
Also included here is a new Tab with Worker Details and the ability to update the team, department, location and manager attributes on the worker. Editable fields are configurable.

Checklist

  • Tested changes end to end
  • Updated documentation
  • Requested one or more reviewers

@ldvlgr ldvlgr marked this pull request as draft October 10, 2023 13:43
@github-actions
Copy link

github-actions bot commented Oct 10, 2023

0 ESLint error(s) and 0 ESLint warning(s) found in pull request changed files.
0 ESLint error(s) and 0 ESLint warning(s) found in files outside of the pull request.

✅ No issues found!

@ldvlgr ldvlgr added the enhancement New feature or request label Oct 10, 2023
@ldvlgr ldvlgr marked this pull request as ready for review October 17, 2023 15:12
@ldvlgr ldvlgr added the ready-for-review PR is ready to be review label Oct 17, 2023
@ldvlgr ldvlgr requested a review from jared-hunter October 23, 2023 14:14
Copy link
Contributor

@jared-hunter jared-hunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a great looking feature - some things we need to tidy up to keep it inline with the conventions in the template.

Main issue:

  • As it stands attribute-viewer and supervisor-capacity dont work unless you also enable worker-canvas

Reason:
this is because there are no hooks for those features on the worker canvas anymore

Solution:
To fit with the pattern of cross-feature dependencies we have

if feature B depends on feature A performing operational logic. Feature A should expose an action that can be invoked by feature B (example of conversations exposing an action for invoking an external warm transfer and custom-transfer-directory using it)

if feature B depends on feature A for rendering location. Feature B should check if Feature A is enabled, and render appropriately (example in canned-responses rendering differently depending on presence of enhancedCRMContainer)

In this case its a bit of both....

worker-canvas-tabs should expose an action to register the tab (you can see an example in enhanced crm container, registering the action here and how it is used to hook in components for rendering here

Then the attribute-viewer and supervisor-capacity features can run independently or with worker-canvas

The alternative solution (and actually my preference) is to combine these features together so that the worker-canvas-tabs piece is always enforced by the feature (why would you not want that?)

so maybe something like a supervisor-worker-canvas-enhancements that brings these al together under one umbrella

let me know your thoughts

@ldvlgr ldvlgr requested a review from jared-hunter November 3, 2023 14:07
@jared-hunter jared-hunter requested review from mvrzan and removed request for jared-hunter November 30, 2023 23:09
@dremin dremin merged commit b1ef8ee into main Jan 23, 2024
5 checks passed
@dremin dremin deleted the worker-canvas-tabs branch January 23, 2024 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready-for-review PR is ready to be review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Tabs on Worker Canvas Side Panel [Skills | Capacity | Attributes] to avoid scrolling
3 participants