-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Worker Canvas Tabs for Skills, Channel Capacity & Worker Attributes #381
Conversation
0 ESLint error(s) and 0 ESLint warning(s) found in pull request changed files. ✅ No issues found! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a great looking feature - some things we need to tidy up to keep it inline with the conventions in the template.
Main issue:
- As it stands attribute-viewer and supervisor-capacity dont work unless you also enable worker-canvas
Reason:
this is because there are no hooks for those features on the worker canvas anymore
Solution:
To fit with the pattern of cross-feature dependencies we have
if feature B depends on feature A performing operational logic. Feature A should expose an action that can be invoked by feature B (example of conversations exposing an action for invoking an external warm transfer and custom-transfer-directory using it)
if feature B depends on feature A for rendering location. Feature B should check if Feature A is enabled, and render appropriately (example in canned-responses rendering differently depending on presence of enhancedCRMContainer)
In this case its a bit of both....
worker-canvas-tabs should expose an action to register the tab (you can see an example in enhanced crm container, registering the action here and how it is used to hook in components for rendering here
Then the attribute-viewer and supervisor-capacity features can run independently or with worker-canvas
The alternative solution (and actually my preference) is to combine these features together so that the worker-canvas-tabs piece is always enforced by the feature (why would you not want that?)
so maybe something like a supervisor-worker-canvas-enhancements that brings these al together under one umbrella
let me know your thoughts
Summary
This enhancement adds Tabs to the Worker Canvas for Skills, Channel Capacity & Worker Attributes.
The existing native WorkerSkills component is removed from the Worker Canvas and added as the first tab.
Supervisor Channel Capacity is moved to the 2nd tab and Worker Attributes viewer to the 3rd tab.
Also included here is a new Tab with Worker Details and the ability to update the team, department, location and manager attributes on the worker. Editable fields are configurable.
Checklist