Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment setup enhancements for Terraform #395

Merged
merged 14 commits into from
Oct 27, 2023
Merged

Environment setup enhancements for Terraform #395

merged 14 commits into from
Oct 27, 2023

Conversation

dremin
Copy link
Contributor

@dremin dremin commented Oct 19, 2023

Summary

  • Adds support for specifying an item's parent in mappings.json. This is useful for child objects such as serverless environments and functions, and has retroactively been applied to TR workflows.
  • Adds support for new types in mappings.json: serverless-environment, serverless-function, and serverless-service.
  • Adds a cache so that results from CLI commands can be reused if needed (serverless-domain makes the same requests as serverless-service and serverless-environment).
  • Adds support for specifying individual files to perform environment variable processing on, as well as support for skipping package processing.

The above work was done as a prerequisite to allow reuse of the setup script for populating Terraform variables (used for objects managed outside of Terraform). This is a first step of reducing the complexity of Terraform deployments:

  • Modified the import_internal_state.sh script to call the setup script to populate an environment-specific tfvars file
  • Modified Terraform config files to use the tfvars file
  • Adjusted scripts to use the Twilio CLI installed by the top-level npm package

Checklist

  • Tested changes end to end
  • Updated documentation
  • Requested one or more reviewers

@dremin dremin added the ready-for-review PR is ready to be review label Oct 19, 2023
@dremin dremin requested a review from jared-hunter October 19, 2023 21:54
@dremin dremin temporarily deployed to dev October 20, 2023 21:39 — with GitHub Actions Inactive
@dremin dremin temporarily deployed to dev October 20, 2023 21:44 — with GitHub Actions Inactive
@dremin dremin temporarily deployed to dev October 20, 2023 21:59 — with GitHub Actions Inactive
@github-actions
Copy link

0 ESLint error(s) and 0 ESLint warning(s) found in pull request changed files.
0 ESLint error(s) and 0 ESLint warning(s) found in files outside of the pull request.

✅ No issues found!

@dremin dremin temporarily deployed to dev October 20, 2023 22:24 — with GitHub Actions Inactive
@dremin dremin temporarily deployed to dev October 20, 2023 22:32 — with GitHub Actions Inactive
@dremin dremin temporarily deployed to dev October 20, 2023 22:37 — with GitHub Actions Inactive
@dremin dremin temporarily deployed to dev October 20, 2023 22:43 — with GitHub Actions Inactive
@dremin dremin temporarily deployed to dev October 20, 2023 22:43 — with GitHub Actions Inactive
@dremin dremin temporarily deployed to dev October 20, 2023 22:45 — with GitHub Actions Inactive
@dremin dremin temporarily deployed to dev October 20, 2023 22:45 — with GitHub Actions Inactive
@dremin dremin marked this pull request as draft October 20, 2023 22:49
@dremin dremin removed the ready-for-review PR is ready to be review label Oct 20, 2023
@dremin dremin temporarily deployed to dev October 20, 2023 22:49 — with GitHub Actions Inactive
@dremin dremin changed the title Environment setup enhancements for future Terraform improvements Environment setup enhancements for Terraform Oct 20, 2023
@dremin dremin added the ready-for-review PR is ready to be review label Oct 20, 2023
@dremin dremin marked this pull request as ready for review October 20, 2023 23:23
@jared-hunter jared-hunter temporarily deployed to jared-test-deploy October 25, 2023 17:58 — with GitHub Actions Inactive
Copy link
Contributor

@jared-hunter jared-hunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, i love these improvements

@dremin dremin merged commit 2e22c1d into main Oct 27, 2023
5 checks passed
@dremin dremin deleted the env-setup-parent branch October 27, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-review PR is ready to be review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants