update nightly e2e

twilio · Oct 3, 2024 · ec801ab · ec801ab
1 parent 543c81d
commit ec801ab
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 14 deletions.
diff --git a/.github/workflows/e2e_scheduled.yaml b/.github/workflows/e2e_scheduled.yaml
@@ -16,6 +16,8 @@ jobs:
       NPM_IGNORE_PREFIX: ${{ vars.NPM_IGNORE_PREFIX }}
       PACKAGE_VERSION: latest
       FLEX_UI_VERSION: latest
+      SLACK_TITLE: 'Flex Plugins CLI - E2E Nightly'
+      SEND_NOTIFICATION: true
     secrets:
       CONSOLE_EMAIL: ${{ secrets.CONSOLE_EMAIL }}
       CONSOLE_PASSWORD: ${{ secrets.CONSOLE_PASSWORD }}
@@ -39,6 +41,8 @@ jobs:
       NPM_IGNORE_PREFIX: ${{ vars.NPM_IGNORE_PREFIX }}
       PACKAGE_VERSION: latest
       FLEX_UI_VERSION: latest
+      SLACK_TITLE: 'Flex Plugins CLI - E2E Nightly'
+      SEND_NOTIFICATION: true
     secrets:
       CONSOLE_EMAIL: ${{ secrets.CONSOLE_EMAIL }}
       CONSOLE_PASSWORD: ${{ secrets.CONSOLE_PASSWORD }}
@@ -62,6 +66,8 @@ jobs:
       NPM_IGNORE_PREFIX: ${{ vars.NPM_IGNORE_PREFIX }}
       PACKAGE_VERSION: latest
       FLEX_UI_VERSION: latest
+      SLACK_TITLE: 'Flex Plugins CLI - E2E Nightly'
+      SEND_NOTIFICATION: true
     secrets:
       CONSOLE_EMAIL: ${{ secrets.CONSOLE_EMAIL }}
       CONSOLE_PASSWORD: ${{ secrets.CONSOLE_PASSWORD }}

diff --git a/.github/workflows/manual_alpha_release_v6.yaml b/.github/workflows/manual_alpha_release_v6.yaml
@@ -21,6 +21,9 @@ jobs:
       VERSION: patch
       BRANCH: FLEXY-5323-6.4.2
       ENVIRONMENT: alpha_release
+      SEND_NOTIFICATION: true
+      SLACK_TITLE: 'Manual Alpha Release E2E for Version ${{ github.event.inputs.version }}'
+      SLACK_MESSAGE: 'Release E2E'
     secrets:
       NODE_AUTH_TOKEN: ${{ secrets.NPM_PUBLISH_TOKEN }}
       SLACK_WEB_HOOK: ${{ secrets.SLACK_WEB_HOOK }}

diff --git a/.github/workflows/manual_public_release_v6.yaml b/.github/workflows/manual_public_release_v6.yaml
@@ -43,7 +43,7 @@ jobs:
       PACKAGE_VERSION: 6.4.2
       FLEX_UI_VERSION: latest
       SEND_NOTIFICATION: true
-      SLACK_TITLE: 'Public Manual Release E2E for Version ${{ github.event.inputs.version }}'
+      SLACK_TITLE: 'Public Manual Release v6 E2E for Version ${{ github.event.inputs.version }}'
       SLACK_MESSAGE: 'Release E2E'
     secrets:
       CONSOLE_EMAIL: ${{ secrets.CONSOLE_EMAIL }}

diff --git a/.github/workflows/~reusable_e2e_by_OS.yaml b/.github/workflows/~reusable_e2e_by_OS.yaml
@@ -34,7 +34,7 @@ on:
         description: 'A message passed from the caller workflow, it will be used in slack notification.'
         required: false
         type: string
-        default: 'E2E tests failed for'
+        default: 'E2E tests'
 
     secrets:
       CONSOLE_EMAIL:
@@ -170,12 +170,11 @@ jobs:
     steps:
       - name: Slack Notification
         uses: rtCamp/action-slack-notify@v2
-        if: needs.node20.result != 'success'
         env:
           SLACK_WEBHOOK: ${{ secrets.SLACK_WEB_HOOK }}
-          SLACK_COLOR: failure
+          SLACK_COLOR: needs.node20.result
           SLACK_USERNAME: Github Actions
           SLACK_ICON_EMOJI: ':ship:'
           SLACK_TITLE: '${{ inputs.SLACK_TITLE }} - ${{ inputs.OS }}'
-          SLACK_MESSAGE: '${{ github.repository }}/${{ github.ref }} - ${{ inputs.SLACK_MESSAGE }} ${{ inputs.OS }}.'
+          SLACK_MESSAGE: '${{ github.repository }}/${{ github.ref }} - ${{ inputs.SLACK_MESSAGE }} {{ needs.node20.result }} for ${{ inputs.OS }}.'
           MSG_MINIMAL: actions url
diff --git a/packages/flex-plugin-e2e-tests/src/tests/step006.ts b/packages/flex-plugin-e2e-tests/src/tests/step006.ts
@@ -27,15 +27,6 @@ const testSuite: TestSuite = async ({ scenario, config, secrets, environment }:
     await Browser.app.twilioConsole.login('agent-desktop', secrets.api.accountSid, config.localhostPort, firstLoad);
     await assertion.app.view.agentDesktop.isVisible();
     await assertion.app.view.plugins.plugin.isVisible(plugin.componentText);
-
-    // Verify hot reload
-    // await replaceInFile({
-    //   files: joinPath(plugin.dir, 'src', 'components', 'CustomTaskList', `CustomTaskList.${ext}`),
-    //   from: plugin.componentText,
-    //   to: tmpComponentText,
-    // });
-
-    // await assertion.app.view.plugins.plugin.isVisible(tmpComponentText);
   };
 
   const onError = async (e: any) => {