This repository has been archived by the owner on Nov 19, 2019. It is now read-only.
Resolving test problems on query params order generation by using cor… #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rect data structures
…rect data structures
…rect data structures
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves the problem that test would fail in some organization due to order of generation of query parameters.
If one runs for example
Twilio_TestPhoneNumbers.testTwilioAvailablePhoneNumbers_AreaCodeFilteron an organization where tests fail, one can read on the log
As you can see the order of the query parameters AreaCode/Contains is inverted and therefore it fails to find the resource and answer with a 404