Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix the documentation generation #2058

Merged
merged 1 commit into from
Oct 28, 2024
Merged

chore: fix the documentation generation #2058

merged 1 commit into from
Oct 28, 2024

Conversation

luisrivas
Copy link
Collaborator

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

Pull Request Details

Description

This PR fixes the documentation generation issue caused by an error in the markdown-it dependency.

Issue: markdown-it/linkify-it#111

closes #2051

Before review

  • Updated CHANGELOG.md if necessary
  • Added unit tests if necessary
  • Updated affected documentation
  • Verified locally with npm test
  • Manually sanity tested running locally
  • Included screenshot as PR comment (if needed)
  • Ready for review

@luisrivas luisrivas merged commit a6b0a41 into master Oct 28, 2024
17 of 24 checks passed
@luisrivas luisrivas deleted the chore/patch-the-doc-generation branch December 6, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charliesantos charliesantos charliesantos approved these changes

@manjeshbhargav manjeshbhargav Awaiting requested review from manjeshbhargav

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build is broken
3 participants
@luisrivas @charliesantos @manjeshbhargav