Release 23.12 #710
Merged
Release 23.12 #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## trunk #710 +/- ##
=======================================
Coverage 99.07% 99.07%
=======================================
Files 46 46
Lines 3986 3986
Branches 531 531
=======================================
Hits 3949 3949
Misses 23 23
Partials 14 14 ☔ View full report in Codecov by Sentry. |
rouge8
reviewed
Dec 22, 2023
src/klein/_version.py
Outdated
|
|
||
| from incremental import Version | ||
|
|
||
| __version__ = Version("klein", 23, 5, 0) | ||
| __version__ = Version("Klein", 23, 12, 0, release_candidate=7) |
There was a problem hiding this comment.
do you need to remove the release candidate here?
There was a problem hiding this comment.
That's the final step in release.py. It does an python -m incremental.update --final and that removes the rc from the version number, both here and in all the @since's that are lying around throughout the codebase.
There was a problem hiding this comment.
Ah okay, in that case this looks good to me!
There was a problem hiding this comment.
want to make that official with an "approve"? :)
rouge8
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.