Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

address removal of attrs.validators.provides #764

Merged
merged 3 commits into from
Aug 11, 2024
Merged

Conversation

glyph
Copy link
Member

@glyph glyph commented Aug 11, 2024

fixes #763

@glyph glyph requested a review from a team as a code owner August 11, 2024 21:00
Copy link

codecov bot commented Aug 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.08%. Comparing base (1fa3d70) to head (b4b3424).
Report is 24 commits behind head on trunk.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk     #764   +/-   ##
=======================================
  Coverage   99.07%   99.08%           
=======================================
  Files          46       48    +2     
  Lines        4002     4040   +38     
  Branches      540      544    +4     
=======================================
+ Hits         3965     4003   +38     
  Misses         23       23           
  Partials       14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glyph
Copy link
Member Author

glyph commented Aug 11, 2024

@adiroiban @mgorny I think this is good to go, just needs a review.

We should probably do a fast-following release.

Copy link
Contributor

@twm twm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks @glyph. I'll go ahead and merge this as it also seems to green up the build.

@twm twm merged commit 861a2d0 into trunk Aug 11, 2024
25 checks passed
@twm twm deleted the attrs-provides-deprecation branch August 11, 2024 22:34
@mgorny
Copy link

mgorny commented Aug 12, 2024

Thanks! The patch also seems to green it for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ImportError: cannot import name 'provides' from 'attr.validators' with attrs 24.2.0
3 participants