-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small performance improvements #773
Conversation
@@ -232,6 +231,12 @@ def process(r: object) -> Any: | |||
returns an IRenderable, then render it and let the result of that | |||
bubble back up. | |||
""" | |||
# isinstance() is faster than providedBy(), so this speeds up the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is... maybe a good idea? Depends on how common this case is.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## trunk #773 +/- ##
=======================================
Coverage 99.08% 99.08%
=======================================
Files 48 48
Lines 4042 4045 +3
Branches 544 545 +1
=======================================
+ Hits 4005 4008 +3
Misses 23 23
Partials 14 14 ☔ View full report in Codecov by Sentry. |
@itamarst this looks unobjectionable but I am curious if you could set up codespeed first, so as to get a baseline? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates.
It looks like this is waiting in the review queue for a long time.
I think that is best to merge it, witout waiting for other tasks.
We can setup codespeed in a separate PR.
Fixes #755
Tested with