Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test to avoid regression in the alias handling #588

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

tristanlatr
Copy link
Contributor

@tristanlatr tristanlatr commented May 23, 2022

This PR only adds a new test.

We can see that for Attributes, first analyzed assignent wins. But for the Classes, it's something else

@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

Base: 92.31% // Head: 92.31% // No change to project coverage 👍

Coverage data is based on head (aa14265) compared to base (5393bd8).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #588   +/-   ##
=======================================
  Coverage   92.31%   92.31%           
=======================================
  Files          45       45           
  Lines        7959     7959           
  Branches     1736     1736           
=======================================
  Hits         7347     7347           
  Misses        356      356           
  Partials      256      256           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tristanlatr tristanlatr marked this pull request as draft May 23, 2022 20:36
@tristanlatr
Copy link
Contributor Author

Closing this in favour of #589 which includes this test.

@tristanlatr tristanlatr reopened this Jul 12, 2022
@tristanlatr tristanlatr marked this pull request as ready for review July 12, 2022 13:50
@tristanlatr
Copy link
Contributor Author

Since this PR only adds a new test, I'll merge it as soon as the status is green.

Copy link
Member

@adiroiban adiroiban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants