Explicit annotation wins over inferred type #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #691 +/- ##
=======================================
Coverage 92.66% 92.66%
=======================================
Files 47 47
Lines 8164 8169 +5
Branches 1954 1955 +1
=======================================
+ Hits 7565 7570 +5
Misses 343 343
Partials 256 256
☔ View full report in Codecov by Sentry. |
|
The are cases where the inherited annotations from a class in another module won be able to resolve in their new context… I’m not sure what to do with these… |
…doctor into 690-explicit-annotations-wins
tristanlatr
commented
May 23, 2023
tristanlatr
commented
May 23, 2023
|
I’ll merge this PR next week if there is still no review. |
glyph
approved these changes
Jul 10, 2023
tristanlatr
commented
Jul 11, 2023
pydoctor/model.py
Outdated
Comment on lines
1454
to
1459
| for attrib in self.objectsOfType(Attribute): | ||
| # If this attribute has not explicit annotation, | ||
| # infer its type from it's ast expression. | ||
| if attrib.annotation is None and attrib.value is not None: | ||
| # do not override explicit annotation | ||
| attrib.annotation = astutils.infer_type(attrib.value) |
There was a problem hiding this comment.
This code will not be compatible with the new changes https://github.com/twisted/pydoctor/pull/723/files in the sens that type inference should be done when leaving a module other wise it's parsed_type will not be transformed by _ReferenceTransform .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #690
Before
After:
