Refactor attrs support into reusable code #719
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #719 +/- ##
==========================================
- Coverage 92.68% 92.66% -0.03%
==========================================
Files 47 48 +1
Lines 8180 8231 +51
Branches 1959 1970 +11
==========================================
+ Hits 7582 7627 +45
- Misses 343 347 +4
- Partials 255 257 +2
☔ View full report in Codecov by Sentry. |
tristanlatr
commented
Jun 11, 2023
tristanlatr
commented
Jun 11, 2023
pydoctor/astutils.py
Outdated
| decorator_list:List[ast.expr] | ||
|
|
||
| def iter_decorators(node:_HasDecoratorList, ctx: 'model.Documentable') -> Iterator[Tuple[Optional[str], ast.AST]]: |
There was a problem hiding this comment.
This function could be removed
…ydoctor into 718-dataclass-like-abstraction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help build code to support
dataclasssandnamedtuplewithout too much preliminary refactors.