Post processors priority #726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iority 200. Adjust tests to avoid the new warning.
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #726 +/- ##
==========================================
+ Coverage 92.68% 92.71% +0.02%
==========================================
Files 47 47
Lines 8180 8207 +27
Branches 1959 1963 +4
==========================================
+ Hits 7582 7609 +27
Misses 343 343
Partials 255 255
☔ View full report in Codecov by Sentry. |
tristanlatr
commented
Jul 16, 2023
|
This is an easy review @buhtz, if you have time to help :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Give the possibility register post processors with handling of processing order based on priority number.
This is how I plan to handle the fact that link transformation (#723) should happen in post-processing after MRO computing and before reparenting. While the zope interafce post processor is designed to be executed after reparenting.
This should be an easy review.