Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release pydoctor 23.9.0 #734

Merged
merged 3 commits into from
Sep 24, 2023
Merged

Release pydoctor 23.9.0 #734

merged 3 commits into from
Sep 24, 2023

Conversation

tristanlatr
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Sep 10, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.04% ⚠️

Comparison is base (4e05370) 92.68% compared to head (f827df8) 92.65%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #734      +/-   ##
==========================================
- Coverage   92.68%   92.65%   -0.04%     
==========================================
  Files          47       47              
  Lines        8180     8180              
  Branches     1959     1959              
==========================================
- Hits         7582     7579       -3     
- Misses        343      345       +2     
- Partials      255      256       +1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tristanlatr tristanlatr requested a review from glyph September 10, 2023 15:35
@tristanlatr
Copy link
Contributor Author

Up

@tristanlatr
Copy link
Contributor Author

Can you leave an approval here, @buhtz ? Thanks a lot.

Copy link
Member

@adiroiban adiroiban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing another release.

This PR looks good.

You can wait for other to test the release, but I think that with gitHub actions passing, this can be merged.

thanks again

@tristanlatr
Copy link
Contributor Author

Arf, i dont understand all these errors during the twisted build, i might have released a bogus version... Can you check on it @adiroiban ?

@tristanlatr
Copy link
Contributor Author

The issue is not reproducible locally :/

@tristanlatr
Copy link
Contributor Author

Ok, it's because we're running with python3.6 and it fails to parse defer.py.
I'll fix that...

@tristanlatr tristanlatr merged commit f03223c into master Sep 24, 2023
19 checks passed
@tristanlatr
Copy link
Contributor Author

All fixed now.

@adiroiban
Copy link
Member

thanks for the release! Happy to see this fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants