Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework reparenting #739

Draft
wants to merge 18 commits into
base: master
Choose a base branch
from
Draft
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Better docs
  • Loading branch information
tristanlatr committed Apr 3, 2024
commit 43276e0518ebc219b11a541a6c2410510e5e37eb
5 changes: 1 addition & 4 deletions pydoctor/model.py
Original file line number Diff line number Diff line change
@@ -351,8 +351,8 @@
break
try:
nxt = self.system.objForFullName(full_name)
except RecursionError:
break

Check warning on line 355 in pydoctor/model.py

Codecov / codecov/patch

pydoctor/model.py#L354-L355

Added lines #L354 - L355 were not covered by tests
if nxt is None:
break
obj = nxt
@@ -1117,9 +1117,6 @@
print('')

def objForFullName(self, full_name: str, raise_missing:bool=False) -> Optional[Documentable]:
# return self.allobjects.get(fullName)

# def find_object(self, full_name: str) -> Optional[Documentable]:
"""Look up an object using a full name.

Works with potentially outdated full anmes as well.
@@ -1131,7 +1128,7 @@
@return: The object, or L{None} if the name is external (it does not
match any of the roots of this system).
@raise LookupError: If the object is not found, while its name does
match one of the roots of this system.
match one of the roots of this system and C{raise_missing=True}.
"""
obj = self.allobjects.get(full_name)
if obj is not None:
Loading