Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

743 fix noise #744

Merged
merged 3 commits into from
Nov 17, 2023
Merged

743 fix noise #744

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9cab66f
Fix ambiguous annotation noise
tristanlatr Nov 2, 2023
8463f13
Add readme entry
tristanlatr Nov 2, 2023
09243b3
Merge branch 'master' into 743-fix-noise
tristanlatr Nov 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ This is the last major release to support Python 3.7.
* Add support for Python 3.12
* `ExtRegistrar.register_post_processor()` now supports a `priority` argument that is an int.
Highest priority callables will be called first during post-processing.
* Fix too noisy ``--verbose`` mode (suppres some ambiguous annotations warnings).

pydoctor 23.9.1
^^^^^^^^^^^^^^^
Expand Down
2 changes: 1 addition & 1 deletion pydoctor/linker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ def warn_ambiguous_annotation(self, target:str) -> None:
# report a low-level message about ambiguous annotation
mod_ann = self._module.expandName(target)
obj_ann = self._scope.expandName(target)
if mod_ann != obj_ann:
if mod_ann != obj_ann and '.' in obj_ann and '.' in mod_ann:
self.obj.report(
f'ambiguous annotation {target!r}, could be interpreted as '
f'{obj_ann!r} instead of {mod_ann!r}', section='annotation',
Expand Down