Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Little fix for re-export names imported from package wildcard #761

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

tristanlatr
Copy link
Contributor

@tristanlatr tristanlatr commented Jan 17, 2024

Fixes #604

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (662eafa) 92.69% compared to head (2bf14a9) 92.69%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #761   +/-   ##
=======================================
  Coverage   92.69%   92.69%           
=======================================
  Files          47       47           
  Lines        8285     8285           
  Branches     1826     1826           
=======================================
  Hits         7680     7680           
  Misses        347      347           
  Partials      258      258           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This comment has been minimized.

1 similar comment
Copy link

According to pydoctor_primer, this change doesn't affect pydoctor warnings on a corpus of open source code. ✅

@tristanlatr
Copy link
Contributor Author

I was sure this would fix some warnings…

@tristanlatr tristanlatr merged commit 1b66928 into master Jan 17, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-export names imported from package wildcard is buggy
1 participant