Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding hasOwnProperty check to stop lookup on the prototype #209

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

serahhh
Copy link

@serahhh serahhh commented Oct 24, 2014

I had a key called 'values' in my data object but findInScope was finding Array.prototype.values, causing my template to not render properly. See jsfiddle: http://jsfiddle.net/h8v2goby/

Added a hasOwnProperty check to fix this.

@CLAassistant
Copy link

CLAassistant commented Jul 18, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Sarah Hayman seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants