-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #59
base: master
Are you sure you want to change the base?
Conversation
viewportEntered will get set to false unless this is set. not sure if this is a bug in ember-in-viewport: DockYard/ember-in-viewport#181
Not sure if I should take anything from this branch as well |
add ember-cli-htmlbars to deps as its required for addons with templates
* Add an integration test for rendering the component, I left one unit test for checking the default settings. * Moved the cache to app/storages like the docs for ember-cli-local storage suggest, probably should rename this to something like ember-lazy-image-cache. * Removed other code from the component that seemed unused.
I've almost got the tests passing, down to two failures:
Not sure what the issue is with this one, if I look at the local storage in the devtools after the tests run I can see the cache is set properly. I tried wrapping the check for the cache in I think this has to do with whether
I thought passing the |
I think I got everything working on the latest versions of ember.
I also
Still working on getting the tests passing...