This repository has been archived by the owner on Mar 22, 2023. It is now read-only.
logging and import cleanup in process_request.clj #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cleans up unused imports makes logs consistently start with lower-case characters
shamsimam
force-pushed
the
debug-response-headers
branch
from
8ee7415 to
d31bd90
Compare
nsinkov
reviewed
Jun 26, 2019
| @@ -507,6 +512,8 @@ | |||
| [post-process-async-request-response-fn _ instance-request-properties descriptor instance | |||
| {:keys [uri] :as request} reason-map reservation-status-promise confirm-live-connection-with-abort | |||
| request-state-chan {:keys [status] :as response}] | |||
| (when (utils/request->debug-enabled? request) | |||
| (log/info "backend response status:" (:status response)"and headers:" (:headers response))) | |||
There was a problem hiding this comment.
space missing response)"and headers:"
| @@ -364,7 +369,7 @@ | |||
| (histograms/update! (metrics/service-histogram service-id "request-content-length") content-length) | |||
| (statsd/inc! metric-group "request_content_length" content-length))) | |||
| (catch Exception e | |||
| (log/error e "Unable to track content-length on request"))) | |||
There was a problem hiding this comment.
Just make all these capitalizations a separate PR. Search systematically. Then it will also cover the (log/error "there was a generic error from above
There was a problem hiding this comment.
We are switching to lower-case. This PR changes the instances in this file.
There was a problem hiding this comment.
Let's open a task to replace log/(error|info|warn) .* ?"[A-Z]
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR
Why are we making these changes?
Additional logging helps with debugging individual requests. Code cleanup is general hygiene.