Improve Windows support #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks very much for this! The build failure is due to a misconfiguration of Travis/coveralls, which should be fixed in #27. Please can you rebase this PR on the latest |
* Contans(): fs.Stat can return a Windows-specific errno that should be ignored (ERROR_CANT_RESOLVE_FILENAME) * vfst: On Windows, symlinks should not be created before the things they point to exist (because links to directories are different from links to files, and the difference must be explicitly specified when calling CreateSymbolicLink). Since maps can't be guaranteed to iterate in any particular order, add support for passing a Builder a list of any of the types already supported, so that order is guaranteed. * contains_test: Path names on Windows may not be longer than ~260 characters (some tools and APIs support 32K chars, but not all), so on that platform the long_filename tests are expected to fail. * MkdirAll(): When Windows is asked to make a directory containing a path component that exists but is not a directory, the Windows APIs return (the equivalent of) ENOENT rather than ENOTDIR. This causes MkdirAll() to attempt to recursively create the path, which will fail because it already exists. This is detected correctly but MkdirAll was swallowing the error, causing the test to detect no error when one was expected.
|
Sure thing! I'm happy to fix any issues that may come up. |
|
Many thanks for the contribution! I'll tweak a couple of very minor details and then tag a new version. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25. More discussion is available there.
Notable changes: