Refactor #30
Merged
Refactor #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
txaty
commented
Nov 23, 2023
•
txaty
commented
- Removed goroutine pool (gool). Using goroutine pool causes overhead and increases the complexity of the code base.
- Changed the proof generation method. Now proofGen parallelized algorithm doesn't require two buffers.
- Added fuzzing test.
- More unit tests were added to achieve 100% coverage.
- Refactored many methods and functions.
- Extracted methods and functions to separate files to increase readability.
Signed-off-by: txaty <[email protected]>
Signed-off-by: txaty <[email protected]>
Signed-off-by: txaty <[email protected]>
Signed-off-by: txaty <[email protected]>
Signed-off-by: txaty <[email protected]>
… unit tests. Signed-off-by: txaty <[email protected]>
1. Fix random data block generation; 2. Add fuzzing test for proof gen. Signed-off-by: txaty <[email protected]>
Signed-off-by: txaty <[email protected]>
Signed-off-by: txaty <[email protected]>
Signed-off-by: txaty <[email protected]>
|
Fuzz test failed on 8fedf34. Using the GitHub CLI, download the seed corpus with |
Signed-off-by: txaty <[email protected]>
|
Fuzz test failed on aa3e3ee. Using the GitHub CLI, download the seed corpus with |
Signed-off-by: txaty <[email protected]>
|
Fuzz test failed on 3ab265a. Using the GitHub CLI, download the seed corpus with |
Signed-off-by: txaty <[email protected]>
|
Fuzz test failed on c486d90. Using the GitHub CLI, download the seed corpus with |
Signed-off-by: txaty <[email protected]>
|
Fuzz test failed on 98cd7b1. Using the GitHub CLI, download the seed corpus with |
Signed-off-by: txaty <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #30 +/- ##
===========================================
+ Coverage 98.02% 100.00% +1.97%
===========================================
Files 2 8 +6
Lines 455 441 -14
===========================================
- Hits 446 441 -5
+ Misses 6 0 -6
+ Partials 3 0 -3 ☔ View full report in Codecov by Sentry. |
Signed-off-by: txaty <[email protected]>
Signed-off-by: txaty <[email protected]>
…e Makefile. Signed-off-by: txaty <[email protected]>
…achieving 100% coverage. Signed-off-by: txaty <[email protected]>
…s in new files. Signed-off-by: txaty <[email protected]>
Signed-off-by: txaty <[email protected]>
Signed-off-by: txaty <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.