This repository was archived by the owner on Oct 30, 2020. It is now read-only.
Etcd #4
Open
Etcd #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| resp, err := c.client.Get(rootDir+c.flota, false, false) | ||
| if err != nil { | ||
| return nil |
There was a problem hiding this comment.
Don't you want to return the error here?
There was a problem hiding this comment.
perhaps, but where is the fun in that?
| c.Close() | ||
| resp, err := c.client.Delete(rootDir+c.flota, false) | ||
| if resp == nil || err != nil { | ||
| panic(ErrorUnableToStopCluster) |
There was a problem hiding this comment.
Again, not sure if we really want to panic.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I still need to run a cluster test using this on my beefier machine but you can start reviewing the code changes, I've done a lot of testing (using the shell scripts in coordinate) that the registration and cluster startup works, just not full tests yet. Real cluster test some time this week now that I think the code has settled (waiting for a long running backup on my beefier machine to finish before I can test this out).
@tylertreat