Skip to content

Commit

Permalink
Remove TODO comments
Browse files Browse the repository at this point in the history
  • Loading branch information
jneira committed Sep 3, 2018
1 parent 3df78cc commit cb37ef3
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions etlas/Distribution/Client/Targets.hs
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,6 @@ readUserTargets verbosity targetStrs = do
reportUserTargetProblems verbosity problems
return targets

-- TODO handle etlas.dhall with a new case UserTargetLocalDhallFile
data UserTargetProblem
= UserTargetUnexpectedFile String
| UserTargetNonexistantFile String
Expand Down Expand Up @@ -278,7 +277,6 @@ readUserTarget targetstr =
v | v == nullVersion -> Dependency (packageName p) anyVersion
| otherwise -> Dependency (packageName p) (thisVersion v)

-- TODO handle etlas.dhall case
reportUserTargetProblems :: Verbosity -> [UserTargetProblem] -> IO ()
reportUserTargetProblems verbosity problems = do
case [ target | UserTargetUnrecognised target <- problems ] of
Expand Down Expand Up @@ -425,7 +423,6 @@ expandUserTarget verbosity worldFile userTarget = case userTarget of
UserTargetRemoteTarball tarballURL ->
return [ PackageTargetLocation (RemoteTarballPackage tarballURL ()) ]

-- Handle etlas.dhall case
localPackageError :: FilePath -> String
localPackageError dir =
"Error reading local package.\nCouldn't find etlas.dhall or .cabal file in: " ++ dir
Expand Down Expand Up @@ -494,7 +491,7 @@ readPackageTarget verbosity = traverse modifyLocation
packageDescrOverride = Nothing,
packagePatch = Nothing
}
-- TODO: extract etlas.dhall file

extractTarballPackageCabalFile :: FilePath -> String
-> IO (FilePath, BS.ByteString)
extractTarballPackageCabalFile tarballFile tarballOriginalLoc = do
Expand Down

0 comments on commit cb37ef3

Please sign in to comment.