-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration of dhall #72
Merged
Merged
Changes from all commits
Commits
Show all changes
46 commits
Select commit
Hold shift + click to select a range
4ff0bc8
Add dhall-to-etlas submodule
jneira 1005384
bump up to latest forced tag
jneira d1e8a27
allow build dhall-to-etlas (including allow-newer to true)
jneira acafc3a
add dhall-to-etlas dep to etlas lib
jneira 18b9bd8
Add dhall as a new valid ProjectPackageLocation
jneira 08a5c38
Add project location dir with dhall file
jneira f84ea85
Package with the dhall-to-etlas specific functions
jneira d3674b5
Add deps and module for dhall integration
jneira b879980
Change target selection error msg to include etlas.dhall
jneira 7563699
Include etlas.dhall in projct config
jneira bb0f800
remove duplicated import
jneira f649437
Use cabal parsec to reparse dhall GenericPackageDescription
jneira c7fefaf
Use readDhallGenericPackageDescription
jneira 20157dd
Remove trace
jneira e19793f
Correct extension
jneira 7671ca4
add stub of remove duplicate pkg locations
jneira cc11f3f
bump dhall-to-etlas
jneira 416c0ec
Add GenericPackageDescription as setupWrapper argument
jneira 0a78bae
complete readGenericPackageDescription using dhall file
jneira 4eeccce
stick to master version
jneira f1658f9
use dhall version with caching hashed imports
jneira a354ed4
remove unnecesary log
jneira 7022ccb
Write derived cabal file before self exec methods in setupWrapper
jneira 770c87c
write derived cabal file before self exec mehod
jneira e2d2e06
bump up dhall-to-etlas to last master
jneira 225d8e2
Examine flags to honor --cabal-file arg
jneira 255ea7d
add etlas.dhall file case to (old-)install tarball
jneira 79b0d05
Initial support for etlas.dhall in Targets
jneira c4e5290
Complete support for etlas.dhall in Targets
jneira 95914a6
Continue handling of etlas.dhall
jneira 0d16ef6
set master version of dhall
jneira 28290a5
set correct repo version of dhall
jneira 2aadc55
Add supoort for etlas.dhall in package list cache read
jneira 6f7f477
bump up dhall-to-etlas to master
jneira 3d047d1
Set PARSEC to false and fix compiler errors
jneira 8005435
Enable Parsec again
jneira 1847005
Cherry pick changes of cabal pr 4654 to allow parse of flags with dou…
jneira 1ba5974
set dhall version to 1.17
jneira b473bc5
bump up master version
jneira b6b84e0
correct new dhall version
jneira ab290a2
Pull latest master
jneira 44c6158
Bump up dhall version to 1.17
jneira 2133396
Relax lower bound of directory to remove allow-newer
jneira c59460e
remove overlapping package locations between dhall and cabal
jneira 3df78cc
Bump up version to 1.6.0.0
jneira cb37ef3
Remove TODO comments
jneira File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,6 @@ | ||
[submodule "hackage-security"] | ||
path = hackage-security | ||
url = https://github.com/Jyothsnasrinivas/hackage-security.git | ||
[submodule "dhall-to-etlas"] | ||
path = dhall-to-etlas | ||
url = https://github.com/eta-lang/dhall-to-etlas |
Submodule dhall-to-etlas
added at
428ee1
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do these changes change the parsing behavior or is it just a refactoring?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok looks like a refactor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is weird but testing with .cabal files gave me an error when indexing cassava with PARSEC option. It has an infamous flag with an internal double dash. Dont know why previous etlas version that has PARSEC enabled didnt throw the error
(See 1847005)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a weird thing in that
stack.yaml
in this repo turns on theparsec
flag, while thestack.yaml
in the maineta
repo doesn't. So theetlas
you use normally when doing./cleaninstall.sh
doesn't use parsec.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohhh, ok, however i think i've used etlas installed from its own repo and i dont remember having that error (cassava is always indexed?).. anyway afaik the new flag parser is more robust cause it will support previous and future flag formats
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! :)